-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First version of the candidatebased GhostTrack tagger #14390
First version of the candidatebased GhostTrack tagger #14390
Conversation
A new Pull Request was created by @pvmulder (Petra Van Mulders) for CMSSW_8_1_X. It involves the following packages: DQMOffline/RecoB @cvuosalo, @dmitrijus, @cmsbuild, @deguio, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
||
for(std::vector<CandidatePtr>::const_iterator track = tracks.begin(); track != tracks.end(); ++track) { | ||
kin.add(*(*track)->bestTrack(), 1.0); | ||
// for(TrackRefVector::const_iterator track = tracks.begin(); track != tracks.end(); track++) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here and in other files, please remove commented out code, especially if it's a remainder of now unnecessary debugging step.
If it is needed for some reason, add some comments why, or even compile it and enable with relevant configuration or even compilation switches (ifdef)
@cmsbuild please test |
The tests are being triggered in jenkins. |
-1 Tested at: adcde5f You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests AddOn
I found errors in the following unit tests: ---> test runtestPhysicsToolsPatAlgos had ERRORS
I found errors in the following addon tests: cmsRun /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-05-1100/src/PhysicsTools/PatAlgos/test/IntegrationTest_cfg.py : FAILED - time: date Fri May 6 01:05:19 2016-date Fri May 6 01:04:42 2016 s - exit: 16640 |
@slava77 I will remove the commented lines @slava77 @ferencek is runtestPhysicsToolsPatAlgos failing because I should do this PR in 2 stages? First adding it to RECO, only afterwards to PAT? In case so, is it sufficient to comment 'pfGhostTrackBJetTags' in PhysicsTools/PatAlgos/python/producersLayer1/jetProducer_cfi.py? Or also at other locations? |
@pvmulder, yes, if the goal is to have the output of this tagger in MiniAOD, then the update needs to be done in 2 stages. For now it should be sufficient to comment |
Pull request #14390 was updated. @cvuosalo, @dmitrijus, @cmsbuild, @deguio, @slava77, @vanbesien, @davidlange6 can you please check and sign again. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Pull request #14390 was updated. @cvuosalo, @dmitrijus, @cmsbuild, @deguio, @slava77, @vanbesien, @davidlange6 can you please check and sign again. |
@davidlange6 rebase done. |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 979991b The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals AddOn
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2/step2_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2.log1306.0 step2 runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log135.4 step1 runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log1330.0 step2 runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log10021.0 step2 runTheMatrix-results/10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017/step2_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log25202.0 step2 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log10024.0 step2 runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log
I found errors in the following addon tests: cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PRef --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --eventcontent RAW --fileout file:RelVal_Raw_PRef_DATA.root --filein /store/data/Run2015D/MuonEG/RAW/v1/000/256/677/00000/80950A90-745D-E511-92FD-02163E011C5D.root : FAILED - time: date Thu May 19 17:15:28 2016-date Thu May 19 17:13:50 2016 s - exit: 21248 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
rebasing to the head of 81X turns out to be a bad idea lately |
@cmsbuild please test CMSSW_8_1_X_2016-05-19-1100 is out |
The tests are being triggered in jenkins. |
+1
|
Similar performance for legacy trackbased GhostTrack tagger (black) and candidatebased taggers on AOD (blue) and miniAOD (red)
Agreement between AOD and rerunning from miniAOD reasonable:
Differences to be further investigated.