Use unique_ptr, not auto_ptr, in L1 #14403
Conversation
|
A new Pull Request was created by @wmtan for CMSSW_8_1_X. It involves the following packages: EventFilter/DTTFRawToDigi @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
@rekovic, @mulhearn, @davidlange6 |
|
@wmtan - was waiting to integrate more urgent L1 changes. Now this PR does not merge. Could you rebase it (likely the conflicting changes went into the 1100 IB today) |
|
@davidlange6 Thanks for the info. I will rebase it, most likely tomorrow (Friday). |
|
@davidlange6 This PR was just rebased |
cmsbuild
added
tests-pending
comparison-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #14403 was updated. @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please check and sign again. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
The last use of the deprecated std::auto_ptr in the CMS framework is the "put" interface for EDProducts, which also supports std::unique:ptr. This PR changes all put calls in L1 to use std::unique_ptr instead of std::auto_ptr. Some other instances of std::auto_ptr in L1 may also have been changed to std::unique_ptr. Some (but not all) cases where auto_ptr was passed by reference (a bad practice) and ownership was not transferred were changed to pass a bare pointer instead to make it clear that ownership was not transferred.