Add missing selection rules (GCC 6)

[davidlt]

A unit test and a few workflows are failing with:

----- Begin Fatal Exception 07-May-2016 07:47:06 CEST-----------------------
An exception of category 'FileReadError' occurred while
   [0] Processing run: 1 lumi: 1 event: 13
   [1] Running path 'outpath'
   [2] Calling event method for module PoolOutputModule/'out'
   [3] Reading branch recoBeamHaloSummary_BeamHaloSummary__RECO.
   Additional Info:
      [a] Fatal Root Error: @SUB=TClass::New with placement
cannot create object of class pair<unsigned char,CaloTowerDetId> version 1 at address 0x7f60cfc7df40

----- End Fatal Exception -------------------------------------------------

This missing dictionary is being user by HaloTowerStrip
(DataFormats/METReco/interface/HcalHaloData.h) and we don't have
selection rules for all of the members.

It's currently unknown why this happens on GCC 6 branch. Adding these
rules resolves the issue, tested with 4.29 workflow. It could be related
to std::pair constructors which have been changed in new libstdc++.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

[cmsbuild]

A new Pull Request was created by @davidlt for CMSSW_8_1_X.

It involves the following packages:

DataFormats/METReco

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12872/console

[cmsbuild]

+1
Tested at: be336b5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14416/12872/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14416/12872/summary.html

[slava77]

+1

for #14416 be336b5

• code change is as described
• jenkins tests pass (all are in gcc530)
• local test of 4.29 in CMSSW_8_1_X_2016-05-06-2300 gcc600 confirms the fix works

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1

[slava77]

After this is merged we now have an issue that dictionaries are reported in a wrong location
in CMSSW_8_1_X_2016-05-10-2300
duplicateReflexLibrarySearch.py --dir ./ --lostDefs
gives

./DataFormats/METReco/src/classes_def.xml
  CaloTowers : pair< uint8_t, CaloTowerDetId >
  CaloTowers : vector< pair< uint8_t, CaloTowerDetId > >

This selection/pair definition should be moved to DataFormats/CaloTowers
Looks like I forgot to run this check before signing yesterday.

[davidlt]

Here is the PR: #14450