Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make statics const in CondFormats/PhysicsToolsObjects #1442

Merged
merged 1 commit into from
Nov 15, 2013

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Nov 13, 2013

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_0_X.

Make statics const in CondFormats/PhysicsToolsObjects

It involves the following packages:

CondFormats/PhysicsToolsObjects

@apfeiffer1, @nclopezo, @demattia, @cmsbuild, @rcastello, @ggovi can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@apfeiffer1
Copy link
Contributor

+1
even if the TFormula stuff may cause threading trouble for the whole class ...

@Dr15Jones
Copy link
Contributor

TFormula is a threading problem. But we solve problems one at a time :).

@cmsbuild
Copy link
Contributor

@rcastello
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Nov 15, 2013
Multithreading fixes -- Make statics const in CondFormats/PhysicsToolsObjects
@ktf ktf merged commit 2363037 into cms-sw:CMSSW_7_0_X Nov 15, 2013
@ktf ktf deleted the sr-fix-CondFormats-PhysicsToolsObjects branch November 15, 2013 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants