L1T Minimum Bias Trigger #14458
L1T Minimum Bias Trigger #14458
Conversation
Conflicts: DataFormats/L1Trigger/interface/EtSum.h L1Trigger/L1TCalorimeter/src/firmware/Stage2Layer2EtSumAlgorithmFirmwareImp1.cc
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @mulhearn for CMSSW_8_1_X. It involves the following packages: DataFormats/L1TGlobal @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
| if( (amc-1) != ((bxid-1+3)%9) ) return true; // temporary measure! | ||
| LogDebug("L1T") << "Unpacking AMC " << amc << " for BX " << bxid; | ||
|
|
||
| auto res1_ = static_cast<CaloCollections*>(coll)->getMPJets(); |
There was a problem hiding this comment.
why are these casts needed?
@mulhearn
There was a problem hiding this comment.
The packer framework makes heavy use of downcasting so that specific concrete instances can use a common packer/unpacker interface. I'm not a big fan of downcasting but its tolerable in this case because the concrete implementations reliable know the true (derived) types they are dealing with. We did have one problem related to bad/impossible downcasting in the packers that was fixed in a recent PR.
|
+1 |
cmsbuild
added
l1-approved
fully-signed
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
This PR adds support for an L1T Minimum Bias Trigger.
The 80x version is #14465.