PhysicsTools/MVATrainer : formatting fix for gcc 6.0 misleading-indentation warning #14998
Conversation
|
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_8_1_X. It involves the following packages: PhysicsTools/MVATrainer @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
| @@ -241,7 +241,7 @@ void ProcMLP::trainData(const std::vector<double> *values, | |||
|
|
|||
| if (iteration == ITER_COUNT) | |||
| count++; | |||
| weightSum += weight; | |||
| weightSum += weight; | |||
There was a problem hiding this comment.
is this a case of somebody's space becoming a tab depending on an editor?
There was a problem hiding this comment.
No. count++ and weightSum += wight lined up in my editor. Did the author mean to put both statements in curly braces? I went with the way the compiler sees it.
gartung
changed the title
| @@ -241,7 +241,7 @@ void ProcMLP::trainData(const std::vector<double> *values, | |||
|
|
|||
| if (iteration == ITER_COUNT) | |||
| count++; | |||
| weightSum += weight; | |||
There was a problem hiding this comment.
Is this line intended to be part of the if block on line 242?
gartung
changed the title
gartung
changed the title
gartung
changed the title
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/PhysicsTools/MVATrainer/plugins/mlp_gen.cc:2920:4: warning: this 'for' clause does not guard... [-Wmisleading-indentation]
for(jn=1;jn<=NET.Nneur[il-1]; jn++)
^~~
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/PhysicsTools/MVATrainer/plugins/mlp_gen.cc:2923:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'for'
fprintf(W," ;\n");
^~~~~~~