Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calibration/IsolatedParticles : gcc 6.0 misleading-indentation warning flags potential bug; with formatting fix #15023

Merged
merged 1 commit into from Jun 30, 2016
Merged

Calibration/IsolatedParticles : gcc 6.0 misleading-indentation warning flags potential bug; with formatting fix #15023

merged 1 commit into from Jun 30, 2016

Conversation

gartung
Copy link
Member

@gartung gartung commented Jun 28, 2016

/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/Calibration/IsolatedParticles/plugins/StudyHLT.cc: In member function 'virtual void StudyHLT::analyze(const edm::Event&, const edm::EventSetup&)':
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/Calibration/IsolatedParticles/plugins/StudyHLT.cc:105:1: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if (verbosity > 0)
^~
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/Calibration/IsolatedParticles/plugins/StudyHLT.cc:107:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
int RunNo = iEvent.id().run();
^~~

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_8_1_X.

It involves the following packages:

Calibration/IsolatedParticles

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mmusich
Copy link
Contributor

mmusich commented Jun 29, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 29, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13760/console

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Jun 29, 2016

+1
@bsunanda FYI

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2d79404 into cms-sw:CMSSW_8_1_X Jun 30, 2016
@gartung gartung deleted the Calibration-IsolatedParticles-fix-indent-not-guard branch July 8, 2016 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants