-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamping ALCARECOTkAlCosmicsInCollisions with cosmicDCTracks #15207
Conversation
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_8_1_X. It involves the following packages: Alignment/CommonAlignmentProducer @ghellwig, @vanbesien, @franzoni, @cerminar, @dmitrijus, @cmsbuild, @srimanob, @mmusich, @fabozzi, @hengne, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 787ee7a You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log50202.0 step2 runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log1000.0 step1 DAS Error1001.0 step1 DAS Error1003.0 step1 DAS Error |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 787ee7a You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log50202.0 step3 runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log4.22 step1 DAS Error136.731 step1 DAS Error140.53 step1 DAS Error1000.0 step1 DAS Error1001.0 step1 DAS Error1003.0 step1 DAS Error |
@cmsbuild please test |
The tests are being triggered in jenkins. |
There was an issue with git-cms-merge-topic you can see the log here: |
@cmsbuild please test |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
+1 |
@vanbesien, @dmitrijus, @srimanob, @fabozzi, @hengne gentle reminder, proposed changes in your areas are minor. |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
Revamping ALCARECOTkAlCosmicsInCollisions with cosmicDCTracks (backport of #15207)
This PR revamps the
TkAlCosmicsInCollisions
ALCARECO workflow, making use of the newly availablecosmicDCTracks
from #14520.Added to the
autoAlCa
and RelVal matrix using theNoBPTX
primary datasets.Results obtained using the new worklow have been shown by @aspiezia (original author of the commits):
Outlook: addition of the producer to other PDs might be considered when a dedicated trigger becomes available.
attn: @mschrode @tlampen