Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamping ALCARECOTkAlCosmicsInCollisions with cosmicDCTracks #15207

Merged
merged 2 commits into from
Jul 19, 2016

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 14, 2016

This PR revamps the TkAlCosmicsInCollisions ALCARECO workflow, making use of the newly available cosmicDCTracks from #14520.
Added to the autoAlCa and RelVal matrix using the NoBPTX primary datasets.
Results obtained using the new worklow have been shown by @aspiezia (original author of the commits):

Outlook: addition of the producer to other PDs might be considered when a dedicated trigger becomes available.

attn: @mschrode @tlampen

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_8_1_X.

It involves the following packages:

Alignment/CommonAlignmentProducer
Configuration/AlCa
Configuration/PyReleaseValidation
DQMOffline/Alignment

@ghellwig, @vanbesien, @franzoni, @cerminar, @dmitrijus, @cmsbuild, @srimanob, @mmusich, @fabozzi, @hengne, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @makortel, @tocheng, @Martin-Grunewald, @tlampen, @mschrode, @rociovilar this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mmusich
Copy link
Contributor Author

mmusich commented Jul 14, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 14, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14080/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 787ee7a

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15207/14080/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
50202.0 step2
runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
1000.0 step1
DAS Error
1001.0 step1
DAS Error
1003.0 step1
DAS Error

@mmusich
Copy link
Contributor Author

mmusich commented Jul 15, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 15, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14083/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 787ee7a

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15207/14083/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
50202.0 step3
runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
4.22 step1
DAS Error
136.731 step1
DAS Error
140.53 step1
DAS Error
1000.0 step1
DAS Error
1001.0 step1
DAS Error
1003.0 step1
DAS Error

@mmusich
Copy link
Contributor Author

mmusich commented Jul 15, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 15, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14091/console

@cmsbuild
Copy link
Contributor

There was an issue with git-cms-merge-topic you can see the log here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15207/14125/git-merge-result

@mmusich
Copy link
Contributor Author

mmusich commented Jul 18, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor Author

mmusich commented Jul 19, 2016

+1

@mmusich
Copy link
Contributor Author

mmusich commented Jul 19, 2016

@vanbesien, @dmitrijus, @srimanob, @fabozzi, @hengne gentle reminder, proposed changes in your areas are minor.

@dmitrijus
Copy link
Contributor

+1

@fabozzi
Copy link
Contributor

fabozzi commented Jul 19, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit beb06cd into cms-sw:CMSSW_8_1_X Jul 19, 2016
cmsbuild added a commit that referenced this pull request Jul 26, 2016
Revamping ALCARECOTkAlCosmicsInCollisions with cosmicDCTracks (backport of #15207)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants