Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup unnecessary FWCore/Framework dependencies in DataFormats #15210

Merged
merged 1 commit into from
Jul 18, 2016
Merged

cleanup unnecessary FWCore/Framework dependencies in DataFormats #15210

merged 1 commit into from
Jul 18, 2016

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Jul 15, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 15, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14089/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for CMSSW_8_1_X.

It involves the following packages:

AnalysisDataFormats/EWK
DataFormats/CTPPSAlignment
DataFormats/CTPPSReco
DataFormats/HcalCalibObjects

@ghellwig, @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @franzoni, @cerminar, @slava77, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @tocheng this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cmsbuild
Copy link
Contributor

-1

Tested at: 971d489

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15210/14089/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
50202.0 step2
runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
4.22 step1
DAS Error
136.731 step1
DAS Error
140.53 step1
DAS Error
1000.0 step1
DAS Error
1001.0 step1
DAS Error
1003.0 step1
DAS Error

@cvuosalo
Copy link
Contributor

@cmsbuild please test
Is it worth trying Jenkins again?

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 15, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14101/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #15210 971d489

Correcting BuildFile.xml dependencies in DataFormats directories. There should be no change in compiled output.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-07-14-2300 show no significant differences, as expected.

@ianna
Copy link
Contributor

ianna commented Jul 18, 2016

+1

@davidlange6 davidlange6 merged commit 57b9860 into cms-sw:CMSSW_8_1_X Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants