bsunanda:Run2-TB01 Test beam analysis code #15244
Conversation
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @bsunanda for CMSSW_8_1_X. It involves the following packages: SimG4CMS/HcalTestBeam @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@bsunanda , verbose_ variable is not needed if one uses LogInfo or LogDebug. You do not bring new functionality but make code less readable and one should remember how to set this verbosity level. |
|
Pull request #15244 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again. |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
Pull request #15244 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again. |
|
@civanch I have removed verbose and simplified the examples. The only thing which is mixed is summing up the energies is done in common while filling the tree is rather independent |
|
-1 Tested at: 579ae13 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: DAS Error |
|
+1 |
cmsbuild
added
simulation-approved
fully-signed
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
+1 |
Beam line counter information is needed to compare detailed distribution of TB06 data with MC. The changes are toward that and an optional ROOT tree is provided for this.