-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pixelCluster to support PhaseII #15318
Conversation
A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_8_1_X. It involves the following packages: DataFormats/SiPixelCluster @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild , please test |
The tests are being triggered in jenkins. |
Pull request #15318 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again. |
@cmsbuild , please test |
The tests are being triggered in jenkins. |
so the iorule was wrong, apparently not affecting refit |
I took a look:
|
-1 Tested at: ecee728 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: DAS Error1001.0 step1 DAS Error1003.0 step1 DAS Error |
it looks like we are back to pre-jenkins times for code output checkout at run time. |
last fixes definitely made things better. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
On 8/6/16 3:04 AM, David Lange wrote:
I didn't really think it would matter. Looking at per-job totals, there is a reduction in run2 between 50 and On disk in RECO in 25202 (70 events) there is ~2% increase (0.1% of RECO 94572.8 -> 96273.2 1700 1.8 0.08
|
Is it possible that this breaks processing current (phase0) DQM stream data using 8_1_X? This scenario usually does not exist (probably for good reason), but it would be useful for phase1 online DQM development (since there is no phase1 online yet, and phase1 DQM only lives in 8_1_0). When I try to process run 281727 (available in lookarea on the tracker online DQM development machine) with 8_1_0_pre12, I get this error (almost) all the time:
(almost, since in rare cases one event goes through before the crash) Note that however I can (!) process 272022 from Update: 8_1_0_pre9 (before this was merged) works. (also @dmitrijus @vanbesien ) |
reco data-format shall be considered transient. please start from raw. onlyTracker reco is fully supported and it is faster than reading reco |
Update pixelCluster to support PhaseII
to test reading old reco I refit an event and the result is the same as refitting a new reco file...
in principle one may observe regressions due to the change in maxsize of clusters from 64 to 128
once this is validated and integrated PhaseII wf have to be modified to use standard Run2 or PhaseII sequences (and all specific PhaseII pixel code removed for good)