Use concurrent unordered map for parameter set registry #1555
Conversation
|
A new Pull Request was created by @wmtan for CMSSW_7_0_X. Use concurrent uunordered map for parameter set registry It involves the following packages: DataFormats/Provenance @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
| @@ -396,7 +396,7 @@ | |||
| outputModulePathPositions); | |||
| processEDAliases(proc_pset, processConfiguration->processName(), preg); | |||
| proc_pset.registerIt(); | |||
| pset::Registry::instance()->extraForUpdate().setID(proc_pset.id()); | |||
| pset::setID(proc_pset.id()); | |||
There was a problem hiding this comment.
If this is the process configuration id, why not make the function pset::setProcessConfigurationID
There was a problem hiding this comment.
Looking further, I see it really should b pset::setProcessParameterSetID to match the get call.
|
Pull request #1555 was updated. @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please check and sign again. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
…eterSetRegistry Multithreading fixes -- Use concurrent unordered map for parameter set registry
fix paths in rivet scripts and add variable TEXMFHOME
For thread safety, use tbb::concurrent_unordered_map for the parameter set registry.