-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HGCal Global Reco (using "Sim Particle Flow" in endcaps) #15598
Conversation
@cmsbuild please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_8_1_X. It involves the following packages: RecoEcal/Configuration @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
Looks simple from the perspective of signature collection. |
Yes, that was lucky. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
-1 Tested at: db4024c You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals AddOn
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log135.4 step1 runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log101.0 step1 runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log1000.0 step2 runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log1001.0 step2 runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log1003.0 step2 runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log1306.0 step3 runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log10021.0 step3 runTheMatrix-results/10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017/step3_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log1330.0 step3 runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log136.731 step3 runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2.log9.0 step3 runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log25.0 step3 runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log10424.0 step3 runTheMatrix-results/10424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D1_GenSimFull+DigiFull_2023D1+RecoFullGlobal_2023D1+HARVESTFullGlobal_2023D1/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D1_GenSimFull+DigiFull_2023D1+RecoFullGlobal_2023D1+HARVESTFullGlobal_2023D1.log10024.0 step3 runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log50202.0 step3 runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log11224.0 step3 runTheMatrix-results/11224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3_GenSimFull+DigiFull_2023D3+RecoFullGlobal_2023D3+HARVESTFullGlobal_2023D3/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3_GenSimFull+DigiFull_2023D3+RecoFullGlobal_2023D3+HARVESTFullGlobal_2023D3.log25202.0 step3 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
I found errors in the following addon tests: cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@Fake,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Thu Aug 25 02:55:21 2016-date Thu Aug 25 02:55:09 2016 s - exit: 256 |
huh... ok... I'll look into it... On Wed, Aug 24, 2016 at 8:10 PM, cmsbuild notifications@github.com wrote:
|
@cmsbuild please test |
The tests are being triggered in jenkins. |
Looking at PU200 with MT4 (the nominal workflow configuration) , equivalent of 11424, RSS on 30 events goes up to 16GB (it's 10GB in the middle of the job). Memory profile on my 200 event job with MT16 suggests there is no real memory leak, but that's just a feeling based on observed numbers. @fabozzi something to follow up when defining the relval workflows so that they actually can complete. |
@slava77 can you pin the 2.5-3x increase to any particular module? Likewise for the memory increase? |
It's likely coming from the (currently large) amount of electron fakes and corresponding GSF tracks being seeded. If necessary, I can work to make some quick requirements on the electron seed clusters to reject obvious fakes. Would prefer in another PR. |
The time increase by x2.5-3 is including I/O and other non-threadable stalls (TimeEvent numbers), if I consider pure module time totals (TimeModule numbers) I get a factor of 30 increase. Of these ~1000 seconds per event
|
Here are some plots, comparing 2016 TTbar PU35 with 2023 D3 TTbar PU35 (11424.0) calo towers are not made for HGCAL hbhereco time is some random numbers ECAL barrel looks fairly similar (self-validation) EGamma pf candidates are fairly similar particleFlow charged hadrons are somewhat similar (some differences are from increased acceptance in eta) pf muons rate is down quite a bit there are many more pf photons now .. probably from the fakes or maybe from OOT even more neutral hadrons (are the scales off in HGCAL?) electronSeeds goes to the story of more fakes at the jet level, things look ~OK @lgray please take a look and see if anything stands out as missing or broken that can be fixed in this PR. |
The photons and neutral hadrons going nuts is from the "perfect" reconstruction (especially the huge increase at low pT. I may increase the energy cut to keep neutral candidates in the simulated PF producer, realistically we cannot reconstruct them all! Otherwise this looks more or less like I expect. Next step: add in BH and control electron fakes. |
+1
|
@slava77 just a few comments on your plots:
|
On 8/31/16 6:28 AM, Kevin Pedro wrote:
if phase-2 HB is multi-depth, I'd assume that more zeroes are from there.
|
This PR implements "sim particle flow" that uses the GEANT information to associate reconstructed tracks to reconstructed clusters in the HGCal endcap.
Likewise, HGCal cluster (which are SimClusters introduced in pre10) are introduced to the reconstruction sequence and allowed to seed electrons, photons, etc.
For example below, ak4 jets over the whole fiducial volume:
Another example, ecalDrivenGsfElectrons (there's a bit of a fake problem right now in endcap, to fix):
I tested this using a ttbar workflow for the "LocalReco" scenarios, where I modified the last step to include the full global reconstruction instead.
@sethzenz @kpedro88