Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HGCal Global Reco (using "Sim Particle Flow" in endcaps) #15598

Merged
merged 8 commits into from
Aug 31, 2016

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Aug 24, 2016

This PR implements "sim particle flow" that uses the GEANT information to associate reconstructed tracks to reconstructed clusters in the HGCal endcap.

Likewise, HGCal cluster (which are SimClusters introduced in pre10) are introduced to the reconstruction sequence and allowed to seed electrons, photons, etc.
For example below, ak4 jets over the whole fiducial volume:
screen shot 2016-08-24 at 17 29 02
screen shot 2016-08-24 at 17 35 42

Another example, ecalDrivenGsfElectrons (there's a bit of a fake problem right now in endcap, to fix):
screen shot 2016-08-24 at 17 30 32
screen shot 2016-08-24 at 17 30 47

I tested this using a ttbar workflow for the "LocalReco" scenarios, where I modified the last step to include the full global reconstruction instead.

@sethzenz @kpedro88

@lgray
Copy link
Contributor Author

lgray commented Aug 24, 2016

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Aug 24, 2016
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_8_1_X.

It involves the following packages:

RecoEcal/Configuration
RecoEcal/EgammaClusterAlgos
RecoEcal/EgammaClusterProducers
RecoEgamma/Configuration
RecoEgamma/EgammaElectronAlgos
RecoEgamma/EgammaElectronProducers
RecoEgamma/EgammaIsolationAlgos
RecoEgamma/EgammaPhotonProducers
RecoEgamma/EgammaTools
RecoParticleFlow/Configuration
RecoParticleFlow/PFClusterProducer
RecoParticleFlow/PFClusterTools
RecoParticleFlow/PFProducer
RecoParticleFlow/PFSimProducer

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@mmarionncern, @Sam-Harper, @rafaellopesdesa, @argiro, @cbernet, @bachtis this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Aug 24, 2016

Looks simple from the perspective of signature collection.
It wasn't clear during the meeting that all affected packages are in the reco category.

@lgray
Copy link
Contributor Author

lgray commented Aug 24, 2016

Yes, that was lucky.

@cmsbuild
Copy link
Contributor

Pull request #15598 was updated. @cvuosalo, @fabozzi, @cmsbuild, @srimanob, @slava77, @hengne, @davidlange6 can you please check and sign again.

@lgray
Copy link
Contributor Author

lgray commented Aug 24, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 24, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14720/console

@cmsbuild
Copy link
Contributor

-1

Tested at: db4024c

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15598/14720/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
135.4 step1
runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
101.0 step1
runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log
1000.0 step2
runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log
1001.0 step2
runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log
1003.0 step2
runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log
1306.0 step3
runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
10021.0 step3
runTheMatrix-results/10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017/step3_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log
1330.0 step3
runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log
136.731 step3
runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2.log
9.0 step3
runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
25.0 step3
runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log
10424.0 step3
runTheMatrix-results/10424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D1_GenSimFull+DigiFull_2023D1+RecoFullGlobal_2023D1+HARVESTFullGlobal_2023D1/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D1_GenSimFull+DigiFull_2023D1+RecoFullGlobal_2023D1+HARVESTFullGlobal_2023D1.log
10024.0 step3
runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log
50202.0 step3
runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
11224.0 step3
runTheMatrix-results/11224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3_GenSimFull+DigiFull_2023D3+RecoFullGlobal_2023D3+HARVESTFullGlobal_2023D3/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3_GenSimFull+DigiFull_2023D3+RecoFullGlobal_2023D3+HARVESTFullGlobal_2023D3.log
25202.0 step3
runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
  • AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@Fake,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Thu Aug 25 02:55:21 2016-date Thu Aug 25 02:55:09 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Thu Aug 25 03:09:26 2016-date Thu Aug 25 02:55:17 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Thu Aug 25 02:59:18 2016-date Thu Aug 25 02:55:19 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Thu Aug 25 03:07:03 2016-date Thu Aug 25 02:55:22 2016 s - exit: 256
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@relval25ns,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns --magField 38T_PostLS1 : FAILED - time: date Thu Aug 25 02:55:31 2016-date Thu Aug 25 02:55:23 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Thu Aug 25 03:06:29 2016-date Thu Aug 25 02:55:28 2016 s - exit: 256
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@relval2016,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 --magField 38T_PostLS1 : FAILED - time: date Thu Aug 25 02:55:37 2016-date Thu Aug 25 02:55:29 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Thu Aug 25 02:58:28 2016-date Thu Aug 25 02:55:34 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Thu Aug 25 03:04:21 2016-date Thu Aug 25 02:55:35 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Thu Aug 25 03:06:14 2016-date Thu Aug 25 02:55:40 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_MC.root --fileout file:RelVal_Raw_Fake1_MC_HLT_RECO.root : FAILED - time: date Thu Aug 25 03:05:42 2016-date Thu Aug 25 02:55:45 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Thu Aug 25 02:56:44 2016-date Thu Aug 25 02:55:49 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Thu Aug 25 03:02:09 2016-date Thu Aug 25 02:55:54 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_DATA.root --fileout file:RelVal_Raw_Fake1_DATA_HLT_RECO.root : FAILED - time: date Thu Aug 25 02:56:50 2016-date Thu Aug 25 02:55:58 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Thu Aug 25 03:07:30 2016-date Thu Aug 25 02:56:01 2016 s - exit: 256

@lgray
Copy link
Contributor Author

lgray commented Aug 25, 2016

huh... ok... I'll look into it...

On Wed, Aug 24, 2016 at 8:10 PM, cmsbuild notifications@github.com wrote:

-1

Tested at: db4024c
db4024c

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-
request-integration/PR-15598/14720/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

10021.0 step3

runTheMatrix-results/10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017/step3_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

10424.0 step3

runTheMatrix-results/10424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D1_GenSimFull+DigiFull_2023D1+RecoFullGlobal_2023D1+HARVESTFullGlobal_2023D1/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D1_GenSimFull+DigiFull_2023D1+RecoFullGlobal_2023D1+HARVESTFullGlobal_2023D1.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log

50202.0 step3

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

11224.0 step3

runTheMatrix-results/11224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3_GenSimFull+DigiFull_2023D3+RecoFullGlobal_2023D3+HARVESTFullGlobal_2023D3/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3_GenSimFull+DigiFull_2023D3+RecoFullGlobal_2023D3+HARVESTFullGlobal_2023D3.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

  • AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast
-n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s
GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@Fake
https://github.com/fake,VALIDATION --customise=HLTrigger/
Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO
--beamspot Realistic8TeVCollision : FAILED - time: date Thu Aug 25 02:55:21
2016-date Thu Aug 25 02:55:09 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp
-n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier
"RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/
Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1
--processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout
file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Thu Aug 25
03:09:26 2016-date Thu Aug 25 02:55:17 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data
--scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval
9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT
--customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era
Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein
file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root
: FAILED - time: date Thu Aug 25 02:59:18 2016-date Thu Aug 25 02:55:19
2016 s - exit: 256
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n
10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier
"RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/
Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1
--processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout
file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Thu Aug 25
03:07:03 2016-date Thu Aug 25 02:55:22 2016 s - exit: 256
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast
-n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s
GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,
EI,HLT:@relval25ns,VALIDATION --customise=HLTrigger/
Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO
--beamspot NominalCollision2015 --era Run2_25ns --magField 38T_PostLS1 :
FAILED - time: date Thu Aug 25 02:55:31 2016-date Thu Aug 25 02:55:23 2016
s - exit: 256
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n
10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier
"RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/
Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1
--processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout
file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Thu Aug 25
03:06:29 2016-date Thu Aug 25 02:55:28 2016 s - exit: 256
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast
-n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s
GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,
EI,HLT:@relval2016,VALIDATION --customise=HLTrigger/
Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO
--beamspot NominalCollision2015 --era Run2_2016 --magField 38T_PostLS1 :
FAILED - time: date Thu Aug 25 02:55:37 2016-date Thu Aug 25 02:55:29 2016
s - exit: 256
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp
-n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier
"RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/
Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1
--processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout
file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Thu Aug 25
02:58:28 2016-date Thu Aug 25 02:55:34 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n
10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier
"RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/
Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein
file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root
: FAILED - time: date Thu Aug 25 03:04:21 2016-date Thu Aug 25 02:55:35
2016 s - exit: 256
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc
--scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50
--datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/
Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField
38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root
--fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Thu
Aug 25 03:06:14 2016-date Thu Aug 25 02:55:40 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --mc --scenario=pp
-n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier
"RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/
Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO
--filein file:RelVal_Raw_Fake1_MC.root --fileout
file:RelVal_Raw_Fake1_MC_HLT_RECO.root : FAILED - time: date Thu Aug 25
03:05:42 2016-date Thu Aug 25 02:55:45 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp
-n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier
"RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/
Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein
file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root
: FAILED - time: date Thu Aug 25 02:56:44 2016-date Thu Aug 25 02:55:49
2016 s - exit: 256
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp
-n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier
"RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/
Configuration/CustomConfigs.L1THLT --era Run2_25ns --magField 38T_PostLS1
--processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout
file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Thu Aug 25
03:02:09 2016-date Thu Aug 25 02:55:54 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --data --scenario=pp
-n 10 --conditions auto:run2_data_Fake1 --relval 9000,50 --datatier
"RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/
Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO
--filein file:RelVal_Raw_Fake1_DATA.root --fileout
file:RelVal_Raw_Fake1_DATA_HLT_RECO.root : FAILED - time: date Thu Aug 25
02:56:50 2016-date Thu Aug 25 02:55:58 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n
10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier
"RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/
Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1
--processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout
file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Thu Aug 25
03:07:30 2016-date Thu Aug 25 02:56:01 2016 s - exit: 256


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15598 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABBMOX0rjw0np_woHCUmLs4u7XS6NSciks5qjOuCgaJpZM4JshQH
.

@cmsbuild
Copy link
Contributor

Pull request #15598 was updated. @cvuosalo, @fabozzi, @cmsbuild, @srimanob, @slava77, @hengne, @davidlange6 can you please check and sign again.

@lgray
Copy link
Contributor Author

lgray commented Aug 29, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 29, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14809/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Aug 30, 2016

Looking at PU200 with MT4 (the nominal workflow configuration) , equivalent of 11424, RSS on 30 events goes up to 16GB (it's 10GB in the middle of the job). Memory profile on my 200 event job with MT16 suggests there is no real memory leak, but that's just a feeling based on observed numbers.
The workflow runs at ~20mins/event, about a factor of 2.5-3 increase from this PR.

@fabozzi something to follow up when defining the relval workflows so that they actually can complete.

@lgray
Copy link
Contributor Author

lgray commented Aug 30, 2016

@slava77 can you pin the 2.5-3x increase to any particular module? Likewise for the memory increase?

@lgray
Copy link
Contributor Author

lgray commented Aug 30, 2016

It's likely coming from the (currently large) amount of electron fakes and corresponding GSF tracks being seeded. If necessary, I can work to make some quick requirements on the electron seed clusters to reject obvious fakes. Would prefer in another PR.

@slava77
Copy link
Contributor

slava77 commented Aug 30, 2016

The time increase by x2.5-3 is including I/O and other non-threadable stalls (TimeEvent numbers), if I consider pure module time totals (TimeModule numbers) I get a factor of 30 increase.
That's somewhat "natural" given that we have switched from just local reco to full reco with validation included.
The time for common modules didn't change much.
Dropping the output module (writes a lot of tracking particles etc stuff, at about 100MB compressed per event), the remaining modules time changes from 6.6 s/evt to 1007 s/evt.

Of these ~1000 seconds per event

  • ~ 300 s is validation (32 [mix] + 156 [recoMuonV* ] + 90 [tpTo* muon MTV]). Here the muon validation modules ran out of control
  • 700 s is reco-related: (265 [allConversions] + 108 [ecalDrivenElectronSeeds] + 54 [pfTrackElec] + 170 [iterative tracking] + 100 [everything else])

@slava77
Copy link
Contributor

slava77 commented Aug 30, 2016

Here are some plots, comparing 2016 TTbar PU35 with 2023 D3 TTbar PU35 (11424.0)
Some are partly for amusement [a more meaningful comparison should be done vs D1]

calo towers are not made for HGCAL
all_sign749-fake2016vsorig_ttbarpuwf25202p0c_calotowerssorted_towermaker__reco_obj_obj_eta155

hbhereco time is some random numbers
all_sign749-fake2016vsorig_ttbarpuwf25202p0c_hbherechitssorted_hbhereco__reco_obj_obj_time
energy looks kind of funny too (many zeroes)
all_sign749-fake2016vsorig_ttbarpuwf25202p0c_log10hbherechitssorted_hbhereco__reco_obj_obj_energy

ECAL barrel looks fairly similar (self-validation)
all_sign749-fake2016vsorig_ttbarpuwf25202p0c_log10max1e-5 recocaloclusters_particleflowsuperclusterecal_particleflowbasicclusterecalbarrel_reco_obj_correctedenergy

EGamma pf candidates are fairly similar
all_sign749-fake2016vsorig_ttbarpuwf25202p0c_log10recopfcandidates_particleflowegamma__reco_obj_pt
... considering that they are in the barrel only
all_sign749-fake2016vsorig_ttbarpuwf25202p0c_recopfcandidates_particleflowegamma__reco_obj_eta

particleFlow charged hadrons are somewhat similar (some differences are from increased acceptance in eta)
all_sign749-fake2016vsorig_ttbarpuwf25202p0c_log10recopfcandidates_particleflow__reco_obj_pt15

pf electrons are about there
all_sign749-fake2016vsorig_ttbarpuwf25202p0c_log10recopfcandidates_particleflow__reco_obj_pt25

pf muons rate is down quite a bit
all_sign749-fake2016vsorig_ttbarpuwf25202p0c_log10recopfcandidates_particleflow__reco_obj_pt35
mostly from the endcaps ... I'm guessing it's the non-isolated muons that don't pass selections as well anymore
all_sign749-fake2016vsorig_ttbarpuwf25202p0c_recopfcandidates_particleflow__reco_obj_eta32

there are many more pf photons now .. probably from the fakes or maybe from OOT
all_sign749-fake2016vsorig_ttbarpuwf25202p0c_log10recopfcandidates_particleflow__reco_obj_pt45
all_sign749-fake2016vsorig_ttbarpuwf25202p0c_recopfcandidates_particleflow__reco_obj_eta42

even more neutral hadrons (are the scales off in HGCAL?)
all_sign749-fake2016vsorig_ttbarpuwf25202p0c_log10recopfcandidates_particleflow__reco_obj_pt55
all_sign749-fake2016vsorig_ttbarpuwf25202p0c_recopfcandidates_particleflow__reco_obj_eta52

all_sign749-fake2016vsorig_ttbarpuwf25202p0c_log10recopfjets_ak4pfjetschs__reco_obj_et

electronSeeds goes to the story of more fakes
all_sign749-fake2016vsorig_ttbarpuwf25202p0c_recoelectronseeds_electronmergedseeds__reco_obj_dphi1

at the jet level, things look ~OK
wf11424fake25202_ak4pfchs_b_corogen
wf11424fake25202_ak4pfchs_e_corogen

@lgray please take a look and see if anything stands out as missing or broken that can be fixed in this PR.

@lgray
Copy link
Contributor Author

lgray commented Aug 30, 2016

The photons and neutral hadrons going nuts is from the "perfect" reconstruction (especially the huge increase at low pT. I may increase the energy cut to keep neutral candidates in the simulated PF producer, realistically we cannot reconstruct them all!

Otherwise this looks more or less like I expect. Next step: add in BH and control electron fakes.

@slava77
Copy link
Contributor

slava77 commented Aug 30, 2016

+1

for #15598 4c64ac9

  • local reco in D3 2023 scenario is replaced with global reco, in line with the description.
  • jenkins tests pass and comparisons with baseline show no differences (due to change in the workflow directory, comparisons in 11224.0 didn't run
  • details from local tests with D3 scenario can be found earlier in this thread

@lgray
Copy link
Contributor Author

lgray commented Aug 30, 2016

@fabozzi, @srimanob, @hengne please sign off

@davidlange6 davidlange6 merged commit d676382 into cms-sw:CMSSW_8_1_X Aug 31, 2016
@kpedro88
Copy link
Contributor

@slava77 just a few comments on your plots:

  • HGCal has never been added to the CaloTowers algorithm. I think it is currently not intended to be added there.
  • HBHE reco in 2023D3 is still using the generic "upgrade reco" from 62XSLHC. Once the HCAL Phase1 reco development is finished, we can move to that (and delete the generic HCAL upgrade classes from CMSSW entirely).
  • The larger-than-average number of zero-energy HBHE rechits needs some investigation.

@slava77
Copy link
Contributor

slava77 commented Aug 31, 2016

On 8/31/16 6:28 AM, Kevin Pedro wrote:

@slava77 https://github.com/slava77 just a few comments on your plots:

  • HGCal has never been added to the CaloTowers algorithm. I think it
    is currently not intended to be added there.
  • HBHE reco in 2023D3 is still using the generic "upgrade reco" from
    62XSLHC. Once the HCAL Phase1 reco development is finished, we can
    move to that (and delete the generic HCAL upgrade classes from CMSSW
    entirely).
  • The larger-than-average number of zero-energy HBHE rechits needs
    some investigation.

if phase-2 HB is multi-depth, I'd assume that more zeroes are from there.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15598 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/AEdcbjCxY4hv8wFBaP1w-9ywT9aP3cLZks5qlYFpgaJpZM4JshQH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants