Dictionary (classes*h) must have unique namespace or/and struct name #1562
Conversation
The patch does minor cleanups and create unique namespaces based on package name. The change is needed for ROOT6 as classes*h files becomes a payload embedded into ROOT6 dictionary, which is executed in an interpreter (Cling) during dictionary loading procedure. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for CMSSW_7_0_X. Dictionary (classes*h) must have unique namespace or/and struct name It involves the following packages: DataFormats/EcalDigi @deguio, @lveldere, @ianna, @Martin-Grunewald, @mommsen, @thspeer, @rcastello, @perrotta, @civanch, @cmsbuild, @fwyzard, @eliasron, @ktf, @vciulli, @Dr15Jones, @demattia, @mdhildreth, @rovere, @giamman, @slava77, @ggovi, @vadler, @mulhearn, @apfeiffer1, @nclopezo, @danduggan, @emeschi, @alja can you please review it and eventually sign? Thanks. |
|
Jenkins PR testing job was launched. |
|
+1 |
5 similar comments
|
+1 |
|
+1 |
|
+1 |
|
+1 |
|
+1 |
|
+1 |
|
Bypassing to get it in early. |
…ts-v3 ROOT 6 -- Dictionary (classes*h) must have unique namespace or/and struct name.
The patch does minor cleanups and create unique namespaces based
on package name.
The change is needed for ROOT6 as classes*h files becomes a payload
embedded into ROOT6 dictionary, which is executed in an interpreter
(Cling) during dictionary loading procedure.
Very minimal misc. cleanups were done in some cases. Should not change
checksum, it's a technical change. Tested on CMSSW_7_0_ROOT6_X_2013-11-22-0200
only currently. Resolves 10 001 errors on ROOT6 build.
Please, review.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch