Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable HCAL DPG HO filter modules in autoSkim.py (81X) #15784

Merged

Conversation

fabozzi
Copy link
Contributor

@fabozzi fabozzi commented Sep 8, 2016

Same as PR #15776 - for 81X
Includes PR #15777

Enable the following two skim modules proposed by HCAL DPG to autoSkim.py
JetHTJetPlusHOFilter => JetHT PD
SinglePhotonJetPlusHOFilter => SinglePhoton PD

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2016

A new Pull Request was created by @fabozzi for CMSSW_8_1_X.

It involves the following packages:

Configuration/PyReleaseValidation
Configuration/Skimming

@cmsbuild, @srimanob, @davidlange6, @hengne, @fabozzi can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@fabozzi
Copy link
Contributor Author

fabozzi commented Sep 8, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15043/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15784/15043/summary.html

The workflows 136.731 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@fabozzi
Copy link
Contributor Author

fabozzi commented Sep 9, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3a3a77e into cms-sw:CMSSW_8_1_X Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants