-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pixel roc occupancy dqm plots #15820
Conversation
A new Pull Request was created by @gouskos for CMSSW_8_0_X. It involves the following packages: DQM/SiPixelMonitorCluster @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
81x version of this? |
found it, #15821 |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
-1 Tested at: 7d6a50d You can see the results of the tests here: I found follow errors while testing this PR Failed tests: ClangBuild
I found a compilation error while trying to compile with clang: ^ /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_0_X_2016-09-14-2300/src/FWCore/Framework/interface/stream/EDAnalyzerBase.h:68:20: note: overridden virtual function is here virtual void analyze(Event const&, EventSetup const&) = 0; ^ In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-14-2300/src/DQM/SiPixelMonitorCluster/src/SiPixelClusterSource.cc:20: /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-14-2300/src/DQM/SiPixelMonitorCluster/interface/SiPixelClusterSource.h:116:42: error: 'auto' not allowed in function prototype void getrococcupancye(DetId detId,auto const & clustColl,const TrackerTopology\* const pTT, ^~~~ /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-14-2300/src/DQM/SiPixelMonitorCluster/interface/SiPixelClusterSource.h:67:21: warning: 'analyze' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] virtual void analyze(const edm::Event&, const edm::EventSetup&); ^ |
-1 |
Pull request #15820 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
Comparison job queued. |
@dmitrijus @davidlange6 is this PR reasonable now? It would be very useful to have it in the Online release in the coming days. |
+1 |
Add Pixel ROC occupancy plots in ONLINE DQM [both for Barrel and Endcap]
Add Pixel Endcap ROC occupancy for off-track case