add pixel roc occupancy dqm plots

[gouskos]

Add Pixel ROC occupancy plots in ONLINE DQM [both for Barrel and Endcap]
Add Pixel Endcap ROC occupancy for off-track case

[cmsbuild]

A new Pull Request was created by @gouskos for CMSSW_8_0_X.

It involves the following packages:

DQM/SiPixelMonitorCluster
DQM/SiPixelMonitorTrack

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[dmitrijus]

81x version of this?

[dmitrijus]

found it, #15821

[dmitrijus]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15185/console

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[cmsbuild]

-1

Tested at: 7d6a50d

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15820/15185/summary.html

I found follow errors while testing this PR

Failed tests: ClangBuild

• Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 16 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

                 ^
/cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_0_X_2016-09-14-2300/src/FWCore/Framework/interface/stream/EDAnalyzerBase.h:68:20: note: overridden virtual function is here
      virtual void analyze(Event const&, EventSetup const&) = 0;
                   ^
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-14-2300/src/DQM/SiPixelMonitorCluster/src/SiPixelClusterSource.cc:20:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-14-2300/src/DQM/SiPixelMonitorCluster/interface/SiPixelClusterSource.h:116:42: error: 'auto' not allowed in function prototype
       void getrococcupancye(DetId detId,auto const & clustColl,const TrackerTopology\* const pTT,
                                         ^~~~
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-14-2300/src/DQM/SiPixelMonitorCluster/interface/SiPixelClusterSource.h:67:21: warning: 'analyze' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
       virtual void analyze(const edm::Event&, const edm::EventSetup&);
                    ^


[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15820/15185/summary.html

[dmitrijus]

-1
please fix the compiler warnings

[cmsbuild]

Pull request #15820 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

[dmitrijus]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16250/console

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[cmsbuild]

+1
Tested at: a9699dc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15820/16250/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15820/16250/summary.html

[fioriNTU]

@dmitrijus @davidlange6 is this PR reasonable now? It would be very useful to have it in the Online release in the coming days.

[davidlange6]

+1