Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

81X HLT update after-MD3 train #16210

Merged
merged 27 commits into from
Oct 20, 2016

Conversation

Martin-Grunewald
Copy link
Contributor

81X HLT update after-MD3 train

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_8_1_X.

It involves the following packages:

Configuration/HLT
HLTrigger/Configuration

@perrotta, @cmsbuild, @silviodonato, @Martin-Grunewald, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @geoff-smith, @jalimena this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 14, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15725/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 4d610f7

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16210/15725/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
136.731 step2

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step2_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log
1306.0 step2
runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
1330.0 step2
runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log
135.4 step1
runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
25202.0 step2
runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
  • AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@relval2016,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 --magField 38T_PostLS1 : FAILED - time: date Fri Oct 14 09:23:56 2016-date Fri Oct 14 09:09:30 2016 s - exit: 16640

@Martin-Grunewald
Copy link
Contributor Author

@mmusich
Marco, this HLT PR now requires new L1T menus in GTs, namely L1Menu_Collisions2016_v9_m2_xml for the run2 pp GTs (such as run2_mc etc.), and
L1Menu_HeavyIons2016_v0_xml for the run2 pPb GTs (such as run2_mc_pa etc.).
Could you please prepare those and update autoCond.py?
Thanks and best regards
Martin

@mmusich
Copy link
Contributor

mmusich commented Oct 14, 2016

@Martin-Grunewald
Hi Martin, OK, will do!
The pPb key should already be OK now:

$ conddb list 81X_mcRun2_pA_v3 | grep L1TUtm
[2016-10-14 10:39:33,551] INFO: Connecting to pro [frontier://PromptProd/CMS_CONDITIONS]
L1TUtmTriggerMenuRcd                                    -                                                L1Menu_HeavyIons2016_v0_xml   

I'll update the run2_mc, but also the run2_data_relval, right? wf 136.731 is failing as well.

@Martin-Grunewald
Copy link
Contributor Author

Martin-Grunewald commented Oct 14, 2016

@mmusich
136.731 fails in L1REPACK+HLT using auto:run2_hlt_relval

@mmusich
Copy link
Contributor

mmusich commented Oct 14, 2016

@Martin-Grunewald indeed.
I am waiting to see if the changes in most MC Global Tags needed by #16070 can come in time to be included in the update for the L1 menu today. If not, I'll do it in steps and deliver GTs for this PR first.

@Martin-Grunewald
Copy link
Contributor Author

@mmusich

Marco, any idea on the timeline?

Thanks and best regards

Martin

@mmusich
Copy link
Contributor

mmusich commented Oct 18, 2016

@Martin-Grunewald we received the ingredients yesterday night. I'll work on that later today/tomorrow

@mmusich
Copy link
Contributor

mmusich commented Oct 20, 2016

@Martin-Grunewald you can find the updated Global Tags here: #16278

@cmsbuild
Copy link
Contributor

Pull request #16210 was updated. @perrotta, @cmsbuild, @silviodonato, @Martin-Grunewald, @fwyzard, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #16210 was updated. @perrotta, @cmsbuild, @ghellwig, @silviodonato, @cerminar, @Martin-Grunewald, @franzoni, @fwyzard, @mmusich, @davidlange6 can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 20, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15847/console

@Martin-Grunewald
Copy link
Contributor Author

@mmusich
Thanks for the PR, cherry picked and included here to see how the tests now run.

@cmsbuild
Copy link
Contributor

Comparison job queued.

@Martin-Grunewald
Copy link
Contributor Author

+1

@mmusich
Copy link
Contributor

mmusich commented Oct 20, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 337427e into cms-sw:CMSSW_8_1_X Oct 20, 2016
@Martin-Grunewald Martin-Grunewald deleted the 81XHLTAfterMD3Train branch December 8, 2016 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants