-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bsunanda:Phase2-hgx65 New geometry for HGCAL #16254
Conversation
@cmsbuild Please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @bsunanda for CMSSW_8_1_X. It involves the following packages: Geometry/HGCalCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
+1 |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
|
Pull request #16254 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again. |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
|
<PartSelector path="//HGCalEESensitive.*"/> | ||
<Parameter name="Volume" value="HGCalEESensitive" eval="false"/> | ||
<Parameter name="Slope" value="[etaMax:slope]"/> | ||
<Parameter name="GroupingZFine" value="1"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsunanda - why Vector is not used?
@bsunanda - just a general note. Using scram build with debug features is better then modifying the code every time you need to print debug messages:
also using Vector in xml rather then named parameter is safer. |
+1 |
@ianna I shall try to take care of this later |
@civanch Could you approve this so that we can go to HGCal TDR geometry sooner? |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
This gives provision for covering the holes in the HGCAL geometry. Only set to work for SIM only at this moment. Changes for Digi-Reco will come later