-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[80X] Temporary fix for multi-IOV input in MillePede" #16340
Revert "[80X] Temporary fix for multi-IOV input in MillePede" #16340
Conversation
A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_8_0_X. It involves the following packages: Alignment/CommonAlignmentProducer @ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
@davidlange6 for my own education, where do I find the compilation logs pointing to issues with this PR? |
@mmusich You can find it in the first row of the table which points to this log: @davidlange6 why has this not been spotted earlier? I would expect something like this to be covered by the integration tests, but this might be too naive... |
@ghellwig , integration tests are only run for production arch which is slc6_amd64_gcc530 for 80X release cycle. |
btw. why is a non-production architecture a reason to revert a critical fix? |
@smuzaffar thanks for the clarification |
not sure what you see at but I see [cid:1BCCF531-C4DB-4976-B0C6-5649B3387890@cern.ch] On Oct 25, 2016, at 1:15 PM, Marco Musich notifications@github.com wrote: @davidlange6 for my own education, where do I find the compilation logs pointing to issues with this PR? — |
not sure in turn to understand what you mean here, but @ghellwig already answered here: #16340 (comment), thanks! |
Reverts #16136 as it is causing compilation problems for gcc493.