Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[80X] Temporary fix for multi-IOV input in MillePede" #16340

Conversation

davidlange6
Copy link
Contributor

Reverts #16136 as it is causing compilation problems for gcc493.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_8_0_X.

It involves the following packages:

Alignment/CommonAlignmentProducer
Alignment/MillePedeAlignmentAlgorithm

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @tocheng, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@mmusich
Copy link
Contributor

mmusich commented Oct 25, 2016

@davidlange6 for my own education, where do I find the compilation logs pointing to issues with this PR?
I've tried here: https://cmssdt.cern.ch/SDT/cgi-bin/showBuildLogs.py/slc6_amd64_gcc493/www/mon/8.0-mon-23/CMSSW_8_0_X_2016-10-24-2300 but I cannot find it

@ghellwig
Copy link

@mmusich You can find it in the first row of the table which points to this log:
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc493/CMSSW_8_0_X_2016-10-24-2300/Alignment/MillePedeAlignmentAlgorithm

@davidlange6 why has this not been spotted earlier? I would expect something like this to be covered by the integration tests, but this might be too naive...

@smuzaffar
Copy link
Contributor

@ghellwig , integration tests are only run for production arch which is slc6_amd64_gcc530 for 80X release cycle.
These errors only exist for gcc493 arch.

@ghellwig
Copy link

btw. why is a non-production architecture a reason to revert a critical fix?

@ghellwig
Copy link

@smuzaffar thanks for the clarification

ghellwig pushed a commit to gregor-mittag/cmssw that referenced this pull request Oct 25, 2016
…orary-fix_multi-IOV-input_MillePede_80X"

This reverts commit f85785a, reversing
changes made to b4ea679.
@davidlange6
Copy link
Contributor Author

not sure what you see at
https://cmssdt.cern.ch/SDT/cgi-bin/showBuildLogs.py/slc6_amd64_gcc493/www/mon/8.0-mon-23/CMSSW_8_0_X_2016-10-24-2300

but I see

[cid:1BCCF531-C4DB-4976-B0C6-5649B3387890@cern.ch]

On Oct 25, 2016, at 1:15 PM, Marco Musich notifications@github.com wrote:

@davidlange6 for my own education, where do I find the compilation logs pointing to issues with this PR?
I've tried here: https://cmssdt.cern.ch/SDT/cgi-bin/showBuildLogs.py/slc6_amd64_gcc493/www/mon/8.0-mon-23/CMSSW_8_0_X_2016-10-24-2300 but I cannot find it


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@mmusich
Copy link
Contributor

mmusich commented Oct 25, 2016

not sure what you see at https://cmssdt.cern.ch/SDT/cgi-bin/showBuildLogs.py/slc6_amd64_gcc493/www/mon/8.0-mon-23/CMSSW_8_0_X_2016-10-24-2300 but I see [cid:1BCCF531-C4DB-4976-B0C6-5649B3387890@cern.ch]

@davidlange6

not sure in turn to understand what you mean here, but @ghellwig already answered here: #16340 (comment), thanks!

cmsbuild added a commit that referenced this pull request Oct 27, 2016
…c493

[80X] Revert #16340 and fix gcc493 compiler error in #16136
@smuzaffar smuzaffar deleted the revert-16136-temporary-fix_multi-IOV-input_MillePede_80X branch January 21, 2017 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants