Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty TProfile2D bin formatting. #16421

Merged
merged 2 commits into from Nov 7, 2016

Conversation

mbandrews
Copy link
Contributor

@mbandrews mbandrews commented Nov 2, 2016

  • Change default value for empty TProfile2D bins in EcalMEFormatter (only used in offline DQM) to prevent DQM GUI crashes.
  • Remove TProfile2D formatting altogether--empty bins now correctly rendered vs. bins filled with 0 in ROOT 6.

In conjunction with 81X PRs #16422, #16437.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2016

A new Pull Request was created by @mbandrews (Michael Andrews) for CMSSW_8_0_X.

It involves the following packages:

DQM/EcalCommon

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2016

Pull request #16421 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

@mbandrews mbandrews changed the title Temporary TProfile2D fix to prevent offline GUI crashes. Remove empty TProfile2D bin formatting. Nov 2, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2016

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2016

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16172/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2016

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2016

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a62e3f1 into cms-sw:CMSSW_8_0_X Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants