-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible for track selectors to include timing cuts (via a ref) #16610
Conversation
A new Pull Request was created by @cmsbuild for CMSSW_9_0_X. It involves the following packages: CommonTools/RecoAlgos @cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Alternative comparison was/were failed for workflow(s): |
+1 |
+1 Adding capability to make timing cuts in track selector modules via a reference. #16500 is the 81X version of this PR, and it has already been approved. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_9_0_X_2016-11-16-1900 show no significant differences. Further tests were performed for #16500, and they show no significant problems. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
Adds in the capability for making timing cuts in track selector modules via a ref.
Automatically ported from CMSSW_8_1_X #16500 (original by @lgray).