Phase1 Pixel DQM cleanup and online features #16615
Conversation
Needs to be explicitly used, and .custom() has to be called to perform the reset if necessary. Currently only resets Histograms that have a special scond axis designed for this, but could also be applied to all.
- updates the SpecificationBuilder to a new output format and fixes some bugs that the new Builder uncovered. - got rid of lots of bad code step1. - There was a systematic problem with perEventHarvesting; we need to be passed the Event*, else there will always be weird cases. - Lots of harvesting features (all 2D EXTEND) removed. - new format for step1 specs simplifies all step1 processing (including booking) - Many long-standing minor issues resolved (booking/harvesting performance, the pre-lumi-Conters issue, etc.)
The new structure uncovered a problem in per-event harvesting that can only be solved with a backwards-incompatible change.
|
A new Pull Request was created by @cmsbuild for CMSSW_9_0_X. It involves the following packages: DQM/SiPixelPhase1Clusters @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
Also configure phase1 DQM for pilot blade
Still not sure if it looks good, but it should be better now.
This config loads 2017 RelVal data, and it meant to run on lxplus or another non-P5 machine.
|
Update (can't edit the comment): The new commits add another "cleanup" (make harvesting functions more useful) and import all of the cahnges that were develloped for the Phase0 online/Pilot blade setup.
|
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
Comparison job queued. |
|
+1 |
This PR is another set of accumulated changes of the last weeks.
The biggest item is a significant rewrite of the HistogramManager. A number of features that are not used by the current DQM histograms were removed, a number of bugs and inconsistencies fixed, it is faster than before and yet it should be easier to follow and understand the code now. The new implementation behaves almost the same as the old one, so plugins were only changed to fix bugs uncovered.
Second item is a new feature for online, to get histograms that are reset after a few lumisections but always retain some history. Together with a special renderplugin (Phase1+PilotBlade Online Trends Render Plugin dmwm/deployment#402) this allows showing multiple, overlaid curves over time, which could be useful especially for detector comissioning.
Minor changes include removing the
defaultGroupingstring, which was replaced by a more high-level approach (default specifiactions) and updating the README to reflect this and a bunch of other changes that happened after writing.Automatically ported from CMSSW_8_1_X #16482 (original by @schneiml).