Timing information in PF

[cmsbuild]

As presented in the Reco meeting of 02/11/16 ( https://indico.cern.ch/event/581218/ ), with a few updates: added timeError on PFClusters and time for PU vertices.

DataFormats:
add support for timing in PF objects

• time() and timeError() added to PFCandidate and PFBlockElement
• timeError() added to PFCluster (before, it had only time()), and changed doubles to floats

Reco:
minimal implementation of timing in PFCandidates

• in the pase2_timing era, MIP timing is propagated from the ValueMaps to the charged PFCandidates
• PFCluster timing is propagated to PFCandidates (for E/gamma candidates, the timing is taken from the seed cluster)

MC Truth information:
add some truth information in AOD formats

• genParticleProducer saves t0 and xyz0 of the true signal vertex also saved as a global float and a XYZPointF object
• getPU_times() added to PileupSummaryInfo and filled if the phase2_timing era

Framework:

• support for modifying VPSets entries in eras

@bendavid @lgray @bachtis

Automatically ported from CMSSW_8_1_X #16450 (original by @gpetruc).

[cmsbuild]

A new Pull Request was created by @cmsbuild for CMSSW_9_0_X.

It involves the following packages:

DataFormats/ParticleFlowCandidate
DataFormats/ParticleFlowReco
DataFormats/PatCandidates
FWCore/ParameterSet
PhysicsTools/HepMCCandAlgos
PhysicsTools/PatAlgos
RecoParticleFlow/PFProducer
RecoParticleFlow/PFSimProducer
SimDataFormats/PileupSummaryInfo
SimGeneral/MixingModule
SimGeneral/PileupInformation

@smuzaffar, @civanch, @Dr15Jones, @cvuosalo, @mdhildreth, @monttj, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @rappoccio, @Martin-Grunewald, @mmarionncern, @imarches, @ahinzmann, @acaudron, @lgray, @jdolen, @ferencek, @wmtan, @rafaellopesdesa, @nhanvtran, @gkasieczka, @schoef, @wddgit, @JyothsnaKomaragiri, @mverzett, @cbernet, @gpetruc, @mariadalfonso, @pvmulder, @bachtis this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16388/console

[slava77]

@cmsbuild please test

****ERROR:Unable to run test_template. Template/Function not found.
SCRAM: Template error --> Can't locate object method "command" via package "BuildSystem::Template::Plugins::PluginCore

in the last build was hopefully transient

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16413/console

[slava77]

@cmsbuild please test

maybe it works this time

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16458/console

[cmsbuild]

-1

Tested at: 440627f

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16619/16458/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test testJetMETCorrectionsType1MET had ERRORS

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16619/16458/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• 20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D1_GenSimHLBeamSpotFull+DigiFull_2023D1+RecoFullGlobal_2023D1+HARVESTFullGlobal_2023D1
• 21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull+DigiFull_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4
• 23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D5_GenSimHLBeamSpotFull+DigiFull_2023D5+RecoFullGlobal_2023D5+HARVESTFullGlobal_2023D5

[slava77]

+1

for #16619 440627f

• the same as in the original 81X (the same topic branch and commit ID).
• jenkins tests pass

[Dr15Jones]

+1
Extension to Modifer is acceptable.