-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed precedence order problem with FormulaEvaluator #16733
Fixed precedence order problem with FormulaEvaluator #16733
Conversation
Under certain conditions one of the evaluation nodes could be dropped because of a faulty precedence handling. Unit tests were also extended to test this case.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_9_0_X. It involves the following packages: CommonTools/Utils @cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
@blinkseb @Dr15Jones we will need 80X and 81X versions of this |
Comparison job queued. |
@slava77 Applying 3b2658f on top of CMSSW 8.0.24 fix the issue, I now have exactly the same output from CMSSW than from ROOT! Thanks a lot! |
Under certain conditions one of the evaluation nodes could be dropped because of a faulty precedence handling.
Unit tests were also extended to test this case.