Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed precedence order problem with FormulaEvaluator #16733

Merged

Conversation

Dr15Jones
Copy link
Contributor

Under certain conditions one of the evaluation nodes could be dropped because of a faulty precedence handling.
Unit tests were also extended to test this case.

Under certain conditions one of the evaluation nodes could be
dropped because of a faulty precedence handling.
Unit tests were also extended to test this case.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_9_0_X.

It involves the following packages:

CommonTools/Utils

@cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 22, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16561/console

@slava77
Copy link
Contributor

slava77 commented Nov 22, 2016

@blinkseb
please confirm that this PR solves the problem

@Dr15Jones we will need 80X and 81X versions of this

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@blinkseb
Copy link
Contributor

@slava77 Applying 3b2658f on top of CMSSW 8.0.24 fix the issue, I now have exactly the same output from CMSSW than from ROOT!

Thanks a lot!

@slava77
Copy link
Contributor

slava77 commented Nov 23, 2016

+1

for #16733 3b2658f

  • fix to formula in JEC not yet released for standard workflows. Resolution is confirmed by @blinkseb
  • jenkins tests pass and comparisons show no differences

@davidlange6 davidlange6 merged commit 9c64be5 into cms-sw:CMSSW_9_0_X Nov 24, 2016
@Dr15Jones Dr15Jones deleted the fixTopNodeFormulaEvaluator branch December 13, 2016 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants