Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert TOB6 and full TEC material to pre8 #16770

Merged
merged 1 commit into from
Dec 1, 2016

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Nov 27, 2016

While retuning the PhaseI Material, all the material within
the tracker volume but outside of the last sensitive
detector has been assigned to this last layer(s). This
caused a major discrepancy in the fbrem quantity that is
used for electronID. For the moment the agreement is to
revert the material of the outermost layers to their status
in pre8 and maybe work together EGamma and GSF experts to
understand if we can do better.

While retuning the PhaseI Material, all the material within
the tracker volume but outside of the last sensitive
detector has been assigned to this last layer(s). This
caused a major discrepancy in the fbrem quantity that is
used for electronID. For the moment the agreement is to
revert the material of the outermost layers to their status
in pre8 and maybe work together EGamma and GSF experts to
understand if we can do better.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_9_0_X.

It involves the following packages:

Geometry/TrackerRecoData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @ghellwig, @VinInn this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@civanch
Copy link
Contributor

civanch commented Nov 27, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 27, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16620/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16770/16620/summary.html

The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@ianna
Copy link
Contributor

ianna commented Nov 28, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c561a57 into cms-sw:CMSSW_9_0_X Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants