-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert TOB6 and full TEC material to pre8 #16770
Conversation
While retuning the PhaseI Material, all the material within the tracker volume but outside of the last sensitive detector has been assigned to this last layer(s). This caused a major discrepancy in the fbrem quantity that is used for electronID. For the moment the agreement is to revert the material of the outermost layers to their status in pre8 and maybe work together EGamma and GSF experts to understand if we can do better.
A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_9_0_X. It involves the following packages: Geometry/TrackerRecoData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
While retuning the PhaseI Material, all the material within
the tracker volume but outside of the last sensitive
detector has been assigned to this last layer(s). This
caused a major discrepancy in the fbrem quantity that is
used for electronID. For the moment the agreement is to
revert the material of the outermost layers to their status
in pre8 and maybe work together EGamma and GSF experts to
understand if we can do better.