QuickTrackAssociatorByHitsProducer throws for missing ClusterTPAssociation input

[makortel]

The effectively-silent fallback has bitten me many times. I think it is a configuration error if useClusterTPAssociation=True and the ClusterTPAssociation collection is missing. In this case I'd prefer to fix my configuration instead of silently falling back to TrackerHitAssociator (not only the latter is slow, but apparently can give different results; I trust ClusterTPAssociation more).

Tested in CMSSW_9_0_X_2016-11-24-2300, no changes expected in standard workflows.

@rovere @VinInn

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_9_0_X.

It involves the following packages:

SimTracker/TrackAssociatorProducers

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@sdevissc, @GiacomoSguazzoni, @rovere, @VinInn, @threus, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16711/console

[cmsbuild]

+1
Tested at: ffa5862
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16833/16711/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16833/16711/summary.html

The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[davidlange6]

+1

[smuzaffar]

@makortel , few workflows are now failing with following error

----- Begin Fatal Exception 02-Dec-2016 19:28:32 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 3
   [1] Running path 'validation_step'
   [2] Calling event method for module MultiTrackValidator/'hiTrackValidator'
   [3] Prefetching for unscheduled module MultiTrackValidator/'hiTrackValidator'
   [4] Calling method for unscheduled module QuickTrackAssociatorByHitsProducer/'trackAssociatorByHitsRecoDenom'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: ClusterTPAssociation
Looking for module label: tpClusterProducer
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

[makortel]

Thanks @smuzaffar, will take a look.

[makortel]

@smuzaffar Fix is in #16864. (I see we don't run any HI MC in the limited matrix)