Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests for Random Numbers. This is for the threaded #1685

Merged
merged 1 commit into from
Dec 8, 2013

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Dec 5, 2013

branch only. Affects unit tests only. Reference files needed
updating plus minor cleanup. The change that caused this problem
was cleanly merged from the 7_0_X branch, but I did not notice
the unit test reference files needed to be different on the
threaded branch. One conflicted and the other did not exist
in 7_0_X.

branch only. Affects unit tests only. Reference files needed
updating plus minor cleanup. The change that caused this problem
was cleanly merged from the 7_0_X branch, but I did not notice
the unit test reference files needed to be different on the
threaded branch. One conflicted and the other did not exist
in 7_0_X.
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2013

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_0_THREADED_X.

Fix unit tests for Random Numbers. This is for the threaded

It involves the following packages:

IOMC/RandomEngine

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@Dr15Jones
Copy link
Contributor

+1

ktf added a commit that referenced this pull request Dec 8, 2013
Multithreading fixes -- Fix unit tests for Random Numbers. This is for the threaded
@ktf ktf merged commit db97a25 into cms-sw:CMSSW_7_0_THREADED_X Dec 8, 2013
@wddgit wddgit deleted the fixRandomNumberUnitTest branch February 11, 2014 16:00
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Revert "Remove patch for symlink and force them through makefile opti…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants