CaloOnlineTools-EcalTools fix clang warning about abs #16919
Conversation
|
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_9_0_X. It involves the following packages: CaloOnlineTools/EcalTools @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
+1 |
warnings.txt:/scratch/gartung/CMSSW_9_0_CLANG_X_2016-12-06-1100/src/CaloOnlineTools/EcalTools/bin/TPGTreeReader.cpp:110:17: warning: using floating point absolute value function 'fabs' when argument is of integer type [-Wabsolute-value]
warnings.txt:/scratch/gartung/CMSSW_9_0_CLANG_X_2016-12-06-1100/src/CaloOnlineTools/EcalTools/bin/TPGTreeReader.cpp:110:17: note: use function 'std::abs' instead