New E/gamma pat::Electron and pat::Photon modifiers

[Sam-Harper]

I wish to embed VID & HEEP V7.0 information into pat::Electrons (and by extension pat::Photons).

This information is stored as a set of ValueMaps. Currently there is
EGExtraInfoModifierFromFloatValueMaps
EGExtraInfoModifierFromIntValueMaps

in RecoEgamma/EgammaTools which do exactly what I need for floats and ints, however I need it for other data types. I diffed EGExtraInfoModifierFromIntValueMaps and EGExtraInfoModifierFromFloatValueMaps to ensure that the only differences were due to types.

As such I propose replacing EGExtraInfoModifierFromIntValueMaps and EGExtraInfoModifierFromFloatValueMaps with a templated class EGExtraInfoModifierFromValueMaps which can read an arbitrary type of ValueMap and write that value as another arbitrary type to the pat::Electron,pat::Photon. The option to write it as an arbitrary type is necessary to for the bool and uints as pat::PATObject has no way to store these values. I could have forced them to always store as an int but I dislike that as it violates the principle of least surprise and also if in the future pat::PATObject gains the ability to store bools and uints, this makes it easy to adapt to that case while retaining backwards compatibility.

Note, EGExtraInfoModifierFromIntValueMaps and EGExtraInfoModifierFromIntValueMaps are part of the miniAOD sequence however I see no changes when the new class. As it simply stores the value in pat::PATObject::userFloat and pat::PATObject::userInt, it should either clearly work or not.

Now I hope I have named the files correctly and they are both in the correct location, I wasnt sure exactly what CMS filenaming policy is here for templates classes.

So far E/gamma has been informed about my request but as its the start of the year, I havent heard back from them yet.

[cmsbuild]

A new Pull Request was created by @Sam-Harper for CMSSW_9_0_X.

It involves the following packages:

RecoEgamma/EgammaTools

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@rafaellopesdesa, @lgray this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[slava77]

however I need it for other data types
which other data types will you need and why can't they instead be the float and int which are already supported?
I doubt we will extend the userInt/userFloat to have also userBool,userShort,userUint etc.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17230/console Started: 2017/01/10 15:01

[Sam-Harper]

Hi Slava,

I need to be able to read value maps of uint, bool and vid::CutFlowResult.

The class by default attempts to add the object to userData however when its writing an int or float, it uses userFloat or userInt through specialisations for those types.

Thus I can store my bool as a userInt, I read the edm::ValueMap and then write it to the pat::Electron as a userInt.

[cmsbuild]

+1
Tested at: 8ce0049
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17138/17230/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17138/17230/summary.html

[slava77]

+1

for #17138 8ce0049

• code changes are in line with the description
• jenkins tests pass and comparisons with baseline show no differences as expected
• paranoia check: copy of jenkins outputs for 136.731 and branch-to-branch comparison shows no changes in values based on compressed size

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar