-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr90x L1T developments #17509
Pr90x L1T developments #17509
Conversation
…ration.Eras.Modifier_stage1L1Trigger_cff. It is rather simple. So comment out adding Trees in Ntuplizer for Stage1 for now.
… Configuration.Eras.Modifier_stage1L1Trigger_cff." This reverts commit 6542bfe.
…017_v1_1 and 2017_v1_1_HI to use 2017_v1_1 CaloLayer1 calibrations.
…flect that these are only Layer1 calibrations updated, and we still need updated of Layer2 calibrations in these files.
…ansparent to user
…17 caloParams of Layer1 constnatns.
…roducer. Conflicts: L1Trigger/L1TNtuples/plugins/L1GenTreeProducer.cc
The L1AnalysisGeneratorDataFormat was never created, leading to a segfault when used. Also made muon part functional again. Conflicts: L1Trigger/L1TNtuples/plugins/L1GenTreeProducer.cc
jenkins tests are running now. Note that cms-sw/cmsdist#2830 is already merged. So normal "please test" should also work |
Pull request #17509 was updated. @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please check and sign again. |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
Comparison job queued. |
+1 @rekovic assures me that the class with the static will be gone in a few weeks.. |
@davidlange6 Thanks. The integration of a new EMTF emulator code is forseen on that time scale. |
90x with L1T developments up to l1t-integration-v91.10