-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
90X Fireworks: save and read pixel topology in new format #17527
Conversation
Conflicts: Fireworks/Geometry/interface/FWRecoGeometryESProducer.h
A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_9_0_X. It involves the following packages: Fireworks/Core @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @alja, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
concern with big pixels and local X,YBig pixels can't be stored in parameters. So far I added a prameter (5th in a row) which marks big pixel layout. Its implementation is hardcoded in TrackUtils. When big pixels will be enabled in phase 2, the code has to add new scenario. |
+1 |
@ianna |
@rovere please follow that Sceenshot od 90X sim data and reco 2023 https://amraktad.web.cern.ch/amraktad/cmsRecoGeom-2023D4.root |
Comparison job queued. |
Save pixel topology pramters per given det id like:
pitchX
pitchY
offsetsX == localX(0.f)
offsetY == localY(0.f)