Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

90X Fireworks: save and read pixel topology in new format #17527

Merged
merged 3 commits into from
Feb 16, 2017

Conversation

alja
Copy link
Contributor

@alja alja commented Feb 15, 2017

Save pixel topology pramters per given det id like:
pitchX
pitchY
offsetsX == localX(0.f)
offsetY == localY(0.f)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_9_0_X.

It involves the following packages:

Fireworks/Core
Fireworks/Geometry
Fireworks/Tracks
Geometry/TrackerGeometryBuilder

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @alja, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @ghellwig, @VinInn, @venturia this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 15, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17807/console Started: 2017/02/15 20:01

@alja
Copy link
Contributor Author

alja commented Feb 15, 2017

Validation

I have used Fireworks/Geometry/plugins/ValidateGeometry.cc to cross check model with fireworks::TrackUtils
canvas_1
canvas_1

@alja
Copy link
Contributor Author

alja commented Feb 15, 2017

concern with big pixels and local X,Y

Big pixels can't be stored in parameters. So far I added a prameter (5th in a row) which marks big pixel layout. Its implementation is hardcoded in TrackUtils.

When big pixels will be enabled in phase 2, the code has to add new scenario.

@alja
Copy link
Contributor Author

alja commented Feb 15, 2017

+1

@alja
Copy link
Contributor Author

alja commented Feb 15, 2017

@ianna
Please follow that

@alja
Copy link
Contributor Author

alja commented Feb 15, 2017

@rovere please follow that

Sceenshot od 90X sim data and reco 2023 https://amraktad.web.cern.ch/amraktad/cmsRecoGeom-2023D4.root

2017-02-15
)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@davidlange6 davidlange6 merged commit 848b93b into cms-sw:CMSSW_9_0_X Feb 16, 2017
@alja alja deleted the phase2_90_pixelrecogeo branch April 8, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants