Cumulative updates to HipPy scripting, TwoBodyDecay, Alignment/OfflineValidation and MuonAnalysis/MuscleFit macros

[usarica]

• HipPy scripts have been improved
• HipPy contains preliminary Y(1S) and Z constraints
• TwoBodyDecay package has been revived, was giving token errors before
• Y(1S)->mumu validation in Alignment/OfflineValidation, support from MuonAnalysis/MomentumScaleCalibration
• These changes have already been used in producing the supermed EOY16 tracker alignment candidate currently being used and some of its validations
• The PR is probably one day too late for 900pre5, but we would like to have it included for the earliest possible release.

Ulascan Sarica for the HipPy tracker alignment team

[cmsbuild]

A new Pull Request was created by @usarica (Ulascan Sarica) for CMSSW_9_0_X.

It involves the following packages:

Alignment/HIPAlignmentAlgorithm
Alignment/OfflineValidation
MuonAnalysis/MomentumScaleCalibration
RecoTracker/TrackProducer
TrackingTools/TrajectoryState

@ghellwig, @cvuosalo, @arunhep, @cerminar, @monttj, @cmsbuild, @franzoni, @slava77, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @gpetruc, @jhgoh, @bellan, @makortel, @felicepantaleo, @abbiendi, @GiacomoSguazzoni, @rovere, @VinInn, @calderona, @HuguesBrun, @tocheng, @tlampen, @mschrode, @battibass, @mmusich, @argiro, @trocino, @dgulhan this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[cmsbuild]

Pull request #17559 was updated. @ghellwig, @cvuosalo, @arunhep, @cerminar, @monttj, @cmsbuild, @franzoni, @slava77, @mmusich, @davidlange6 can you please check and sign again.

[usarica]

PR updated to take into ccount the requests from Gregor, no big changes are done.

[ghellwig]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17949/console Started: 2017/02/24 14:14

[ghellwig]

+1
Thanks, Ulascan!
You missed to rename also iterator_py, but you can leave this PR as is and use the next update to correct for that.

[cmsbuild]

+1
Tested at: 8937d04
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17559/17949/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17559/17949/summary.html

[slava77]

+1

for #17559 8937d04

• technical changes unrelated to reco were made since the last reco signoff
• jenkins tests pass and show no differences

[franzoni]

may this PR be given more feedback
or signed by analysis ?
Thanks!

[usarica]

I think there are no more pending issues. Issues outlined by Gregor have been fixed except for a couple which we agreed to postpone for a later PR.

[ghellwig]

I think there are no more pending issues. Issues outlined by Gregor have been fixed except for a couple which we agreed to postpone for a later PR.

That's correct. There is only the analysis signature pending. @monttj, can you please have a look?

[davidlange6]

Hi @usarica - all is ok here except that the large lists of files (eg, in ALCARECOTkAlCosmicsCTF0T.dat_CRUZET_PromptReco) need to be removed. Perhaps they are better in your personal repo if they can not be retrieved from das directly.

Thx

[usarica]

Hi @davidlange6,

The files you point are already shown as removed in the PR. Did I miss any?

There are template files ALCARECOTkAlCosmicsInCollisionsTrackSelection_cff_py.txt, ALCARECOTkAlUpsilonMuMuTrackSelection_cff_py.txt, ALCARECOTkAlZMuMuTrackSelection_cff_py.txt that cannot be removed because the operation of HIPpy depends on them.

[davidlange6]

ah - whoops - yes. Thanks

…

On Mar 2, 2017, at 11:16 AM, Ulascan Sarica ***@***.***> wrote: Hi @davidlange6, The files you point are already shown as removed in the PR. Did I miss any? There are template files ALCARECOTkAlCosmicsInCollisionsTrackSelection_cff_py.txt, ALCARECOTkAlUpsilonMuMuTrackSelection_cff_py.txt, ALCARECOTkAlZMuMuTrackSelection_cff_py.txt that cannot be removed because the operation of HIPpy depends on them. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.