Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cumulative updates to HipPy scripting, TwoBodyDecay, Alignment/OfflineValidation and MuonAnalysis/MuscleFit macros #17559

Merged
merged 22 commits into from Mar 2, 2017

Conversation

usarica
Copy link
Contributor

@usarica usarica commented Feb 18, 2017

  • HipPy scripts have been improved
  • HipPy contains preliminary Y(1S) and Z constraints
  • TwoBodyDecay package has been revived, was giving token errors before
  • Y(1S)->mumu validation in Alignment/OfflineValidation, support from MuonAnalysis/MomentumScaleCalibration
  • These changes have already been used in producing the supermed EOY16 tracker alignment candidate currently being used and some of its validations
  • The PR is probably one day too late for 900pre5, but we would like to have it included for the earliest possible release.

Ulascan Sarica for the HipPy tracker alignment team

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @usarica (Ulascan Sarica) for CMSSW_9_0_X.

It involves the following packages:

Alignment/HIPAlignmentAlgorithm
Alignment/OfflineValidation
MuonAnalysis/MomentumScaleCalibration
RecoTracker/TrackProducer
TrackingTools/TrajectoryState

@ghellwig, @cvuosalo, @arunhep, @cerminar, @monttj, @cmsbuild, @franzoni, @slava77, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @gpetruc, @jhgoh, @bellan, @makortel, @felicepantaleo, @abbiendi, @GiacomoSguazzoni, @rovere, @VinInn, @calderona, @HuguesBrun, @tocheng, @tlampen, @mschrode, @battibass, @mmusich, @argiro, @trocino, @dgulhan this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@cmsbuild
Copy link
Contributor

Pull request #17559 was updated. @ghellwig, @cvuosalo, @arunhep, @cerminar, @monttj, @cmsbuild, @franzoni, @slava77, @mmusich, @davidlange6 can you please check and sign again.

@usarica
Copy link
Contributor Author

usarica commented Feb 23, 2017

PR updated to take into ccount the requests from Gregor, no big changes are done.

@ghellwig
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 24, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17949/console Started: 2017/02/24 14:14

@ghellwig
Copy link

+1
Thanks, Ulascan!
You missed to rename also iterator_py, but you can leave this PR as is and use the next update to correct for that.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Feb 25, 2017

+1

for #17559 8937d04

  • technical changes unrelated to reco were made since the last reco signoff
  • jenkins tests pass and show no differences

@franzoni
Copy link

may this PR be given more feedback
or signed by analysis ?
Thanks!

@usarica
Copy link
Contributor Author

usarica commented Feb 28, 2017

I think there are no more pending issues. Issues outlined by Gregor have been fixed except for a couple which we agreed to postpone for a later PR.

@ghellwig
Copy link

I think there are no more pending issues. Issues outlined by Gregor have been fixed except for a couple which we agreed to postpone for a later PR.

That's correct. There is only the analysis signature pending. @monttj, can you please have a look?

@davidlange6
Copy link
Contributor

Hi @usarica - all is ok here except that the large lists of files (eg, in ALCARECOTkAlCosmicsCTF0T.dat_CRUZET_PromptReco) need to be removed. Perhaps they are better in your personal repo if they can not be retrieved from das directly.

Thx

@usarica
Copy link
Contributor Author

usarica commented Mar 2, 2017

Hi @davidlange6,

The files you point are already shown as removed in the PR. Did I miss any?

There are template files ALCARECOTkAlCosmicsInCollisionsTrackSelection_cff_py.txt, ALCARECOTkAlUpsilonMuMuTrackSelection_cff_py.txt, ALCARECOTkAlZMuMuTrackSelection_cff_py.txt that cannot be removed because the operation of HIPpy depends on them.

@davidlange6
Copy link
Contributor

davidlange6 commented Mar 2, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants