Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize theModMEs.ClusterGain #17678

Merged
merged 2 commits into from
Mar 2, 2017
Merged

Initialize theModMEs.ClusterGain #17678

merged 2 commits into from
Mar 2, 2017

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Mar 2, 2017

This showed up in AArch64 GCC 5.3.0 and 7.0.1 builds.

Signed-off-by: David Abdurachmanov davidlt@cern.ch

Initialize theModMEs.ClusterGain
e3c3b36 
This showed up in AArch64 GCC 5.3.0 and 7.0.1 builds.

Signed-off-by: David Abdurachmanov <davidlt@cern.ch>
@cmsbuild cmsbuild added this to the Next CMSSW_9_0_X milestone Mar 2, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2017

A new Pull Request was created by @davidlt for CMSSW_9_0_X.

It involves the following packages:

DQM/SiStripMonitorTrack

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@davidlt
Copy link
Contributor Author

davidlt commented Mar 2, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2017 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18042/console Started: 2017/03/02 08:37

Initialize inside the struct; Fix ClusterGain overwriting ClusterWidth
5d16967 
Signed-off-by: David Abdurachmanov <davidlt@cern.ch>
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2017

Pull request #17678 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

@davidlt
Copy link
Contributor Author

davidlt commented Mar 2, 2017

please abort test

@davidlt
Copy link
Contributor Author

davidlt commented Mar 2, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2017 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18044/console Started: 2017/03/02 09:04

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2017

+1
Tested at: 5d16967
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17678/18044/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2017

Comparison job queued.

@smuzaffar smuzaffar mentioned this pull request Mar 2, 2017
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17678/18044/summary.html

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6d21e57 into cms-sw:CMSSW_9_0_X Mar 2, 2017
@davidlange6 davidlange6 mentioned this pull request Mar 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_0_X
Development

Successfully merging this pull request may close these issues.
4 participants
@davidlt @cmsbuild @dmitrijus @davidlange6