Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default resolution parameters for iRPCs #18012

Merged
merged 1 commit into from
Mar 24, 2017

Conversation

bapavlov
Copy link
Contributor

Set the default intrinsic timing resolution to the one specified by the iRPC hardware experts (~ 1ns).
Slight change in the digitizer - all the strips in a cluster are digitized now. Before we drop some of the strips, but this leads to unphysical "shift" of the cluster.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bapavlov for master.

It involves the following packages:

SimMuon/RPCDigitizer

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@jhgoh this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@civanch
Copy link
Contributor

civanch commented Mar 21, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 21, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18589/console Started: 2017/03/21 15:51

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Mar 23, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0025bcc into cms-sw:master Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants