-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use presamples and sample variables correctly for HF TP #18169
Conversation
A new Pull Request was created by @matz-e (Matthias Wolf) for master. It involves the following packages: SimCalorimetry/HcalTrigPrimAlgos @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
@rekovic |
@rekovic |
@rekovic |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
Thanks, Vladimir. |
+1 |
Thanks!
…On Fri, 14 Apr 2017, David Lange wrote:
+1
(yes)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the
thread.[AEx02pRLS_34olDaAUtQf7_O_ZrbsL8iks5rvzQzgaJpZM4MxMCQ.gif]
|
Fix a regression for 2016 onwards, where we started using a single settings for presamples instead of separate settings for HF and HBHE.