Use presamples and sample variables correctly for HF TP

[matz-e]

Fix a regression for 2016 onwards, where we started using a single settings for presamples instead of separate settings for HF and HBHE.

[cmsbuild]

A new Pull Request was created by @matz-e (Matthias Wolf) for master.

It involves the following packages:

SimCalorimetry/HcalTrigPrimAlgos

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[kpedro88]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18873/console Started: 2017/04/03 16:18

[cmsbuild]

+1
Tested at: 3995545
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18169/18873/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18169/18873/summary.html

[abdoulline]

@rekovic
may we get it approved, please?

[abdoulline]

@rekovic
there is an update of HF DIGI & TP configs to bring MC and TP emulation in sync with new 2017 data, which waits for this PR to be merged...

[christopheralanwest]

@rekovic
This PR (actually, PR #18170) is also needed in order to monitor the TP emulation for the upgraded HF in DQM, as it enables the number of TP samples and presamples to differ between HBHE and HF, as in the current data. However, by itself, this PR does absolutely nothing: it is purely a renaming of variables, as the default values for numberOfSamples and numberOfPresamples are the same as numberOfSamplesHF and numberOfPresamplesHF, respectively, in the only configuration in which they are currently used:

https://github.com/cms-sw/cmssw/blob/master/SimCalorimetry/HcalTrigPrimProducers/python/hcaltpdigi_cfi.py#L23-L26

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

[abdoulline]

Thanks, Vladimir.
@davidlange6 is there a chance it would make it to pre3?

[davidlange6]

+1
(yes)

[abdoulline]

Thanks!

…

On Fri, 14 Apr 2017, David Lange wrote: +1 (yes) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.[AEx02pRLS_34olDaAUtQf7_O_ZrbsL8iks5rvzQzgaJpZM4MxMCQ.gif]