High pt taus: TauID for 2014 #1817

jpavel · 2013-12-13T22:44:24Z

Large upgrade of PFTau sequence. Main changes are

Change in algorithm logic
Change in data format (new members plus shift from Ref to Ptr)
Addition of tau lifetime information
Addition of boosted tau subjet techniques
Many new discriminants

(forward-port from 5_3_X)

…cer.cc - run CMSBoostedTauSeedingAlgorithm regardless of pruning/filtering being used in addition - added protection against pathological cases to BoostedTauSeedsProducer.cc - minor bug-fix: added missing initialization of useCMSBoostedTauSeedingAlgorithm_ flag (forward-port of commits veelken@6fac048 veelken@045b688 from CMSSW_6_2_X branch) - switched to getByToken and consumes interface - improved include guard and removed cvs specific labels from CMSBoostedTauSeedingAlgorithm.h

…Ptrs where necessary

…s/PFTauElementsOperators in order to resume 'old' HLT path

…om-CMSSW_7_0_X_2013-12-13-1400 Updating with latest developments

cmsbuild · 2013-12-13T22:48:05Z

A new Pull Request was created by @jpavel (Pavel Jez) for CMSSW_7_0_X.

High pt taus: TauID for 2014

It involves the following packages:

DataFormats/PatCandidates
RecoTauTag/TauTagTools
JetMETCorrections/TauJet
CommonTools/ParticleFlow
RecoTauTag/Configuration
RecoTauTag/ImpactParameter
RecoTauTag/RecoTau
DataFormats/JetReco
DataFormats/TauReco
PhysicsTools/PatAlgos
RecoJets/JetAlgorithms
PhysicsTools/IsolationAlgos
Validation/RecoTau
RecoJets/JetProducers
HLTriggerOffline/Tau
RecoParticleFlow/Benchmark

@nclopezo, @danduggan, @rovere, @cmsbuild, @anton-a, @thspeer, @deguio, @slava77, @vadler, @eliasron can you please review it and eventually sign? Thanks.
@TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

cmsbuild · 2013-12-14T23:10:49Z

-1
I ran the usual tests and I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS
---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafTopEventSelection had ERRORS
---> test runtestTqafExamples had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1817/1771/summary.html

…inators will run in CMSSW_7_0_x per default

ktf · 2014-01-20T22:21:49Z

For the record: with @davidlange6 we have decided to go ahead with pre12
(currently uploading). This will end up in some pre13 or in the final
CMSSW_7_0_0. To be discussed tomorrow.

On 20 Jan 2014, at 23:19, slava77 wrote:

OK.
Just to summarize for now: the main issues with the code (performance
and quality) appear to be addressed.
I have started integration tests and will hopefully be able to sign
off tomorrow (AM), assuming nothing bad turns up.

Reply to this email directly or view it on GitHub:
#1817 (comment)

monicava · 2014-01-20T22:28:32Z

And thanks to @slava77 for his heroic effort!

jpavel · 2014-01-20T22:58:15Z

agree with Monica - thank you Slava very much for your effort, patience and help. I will try to keep your coding advice in mind for future developments

slava77 · 2014-01-21T08:45:28Z

Notes on the latest changes (5197cd5..3a08960)

New warnings showed up.
It may be from the last changes in the PV producer, could it be that the same track ends up on the list twice?

%MSG-w TwoTrackMinimumDistance:   PFTauPrimaryVertexProducer:hpsPFTauPrimaryVertexProducer  21-Jan-2014 00:36:06 CET Run: 1 Event: 11272
Computation HelixHelix::CAIR failed.
%MSG
%MSG-w TwoTrackMinimumDistance:   PFTauPrimaryVertexProducer:hpsPFTauPrimaryVertexProducer  21-Jan-2014 00:36:06 CET Run: 1 Event: 11272
comparing track with itself!

It looks like there are no changes in the tau content. So, fixing the above is not urgent, but please keep them on your todo list.

slava77 · 2014-01-21T09:43:47Z

Timing went down by about x2 - 2.5.
One good example, hpsPFTauPrimaryVertexProducer time reduced by x8 in 40PU25ns sample.

slava77 · 2014-01-21T09:44:53Z

+1

tested 3a08960 in CMSSW_7_0_X_2014-01-20-1400 (sign298).
Based on the review above.

slava77 · 2014-01-21T11:23:15Z

@vadler @deguio
Volker and Federico, could you please check this PR and sign it again.

vadler · 2014-01-21T12:42:40Z

+1
The last update does not touch AT.

deguio · 2014-01-21T15:23:39Z

+1
I have only one question to @jpavel and @monicava
Do you really need a web page template to be included in release? Why don't you use the GUI instead?

cmsbuild · 2014-01-21T15:28:16Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

jpavel · 2014-01-21T15:32:46Z

To include the web page template was suggestion/request from the tau POG validation team who use it to store and publish results of the validation for a long time already. Until now they had to copy these scripts from some semi-private areas so inclusion in the release makes it easier to maintain and monitor. Nevertheless, is there a Twiki page describing how to use the validation GUI, which we can forward to our validators so they can learn how use it? This way we can remove the web templates from the release in the future

monicava · 2014-01-21T15:33:06Z

Hi,
Which template are you referring to?
Monica

On 21 Jan 2014, at 16:23, deguio wrote:

+1
I have only one question to @jpavelhttps://github.com/jpavel and @monicavahttps://github.com/monicava
Do you really need a web page template to be included in release? Why don't you use the GUI instead?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1817#issuecomment-32894658.

deguio · 2014-01-21T15:44:58Z

@jpavel
the histograms should be already available in the GUI.
in the following twiki the instructions on how to develop layouts and render plugins and test them using a temporary GUI are reported:
https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMTest#Installing_the_GUI_Server

I hope that helps. we are available if you have questions.
thanks,
F.

monicava · 2014-01-21T15:50:39Z

The time-scale for updating DQM code depends on the release cycle
which can be quite slow, but I recall that also including new layouts and
render plugins took months to happen.
Hast the situation improved on that front?

Thanks,
Monica

On 21 Jan 2014, at 16:45, deguio wrote:

@jpavelhttps://github.com/jpavel
the histograms should be already available in the GUI.
in the following twiki the instructions on how to develop layouts and render plugins and test them using a temporary GUI are reported:
https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMTest#Installing_the_GUI_Server

I hope that helps. we are available if you have questions.
thanks,
F.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1817#issuecomment-32896963.

deguio · 2014-01-21T16:07:00Z

ciao @monicava
you are right. the updates to the DQM code follow the release cycle. layouts and render plugins follows the cmsweb updates instead and they don't depend on us actually. But in standard conditions I don't think that frequent updates are needed. This is the same for all the packages. Am I wrong?
anyway the pull is fine. I was wondering if moving to a GUI based validation is something planned.

thanks,
F.

monicava · 2014-01-21T19:55:51Z

Ciao @deguio!

Thanks, I will ask the computing friends on the cmsweb schedules.

Our goal is to have stable software in Run 2, so that should
ease things in term of monitoring automatisation. The tau
object evolved a lot in the last couple of years so it was
difficult to obtain "useful" central-automatic validation/DQM.
But the plan is of course to go in that direction.

Cheers,
Monica

On 21 Jan 2014, at 17:07, deguio wrote:

ciao @monicavahttps://github.com/monicava
you are right. the updates to the DQM code follow the release cycle. layouts and render plugins follows the cmsweb updates instead and they don't depend on us actually. But in standard conditions I don't think that frequent updates are needed. This is the same for all the packages. Am I wrong?
anyway the pull is fine. I was wondering if moving to a GUI based validation is something planned.

thanks,
F.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1817#issuecomment-32899403.

cmsbuild · 2014-01-22T02:31:01Z

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1817/2147/summary.html

cmsbuild · 2014-01-22T02:33:12Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @ktf can you please take care of it?

vadler · 2014-01-22T16:13:46Z

PhysicsTools/PatAlgos/plugins/PATTauProducer.cc

@@ -33,7 +37,9 @@
 {
  // initialize the configurables
  baseTauToken_ = consumes<edm::View<reco::BaseTau> >(iConfig.getParameter<edm::InputTag>( "tauSource" ));
-  pfTauToken_ = mayConsume<reco::PFTauCollection>(iConfig.getParameter<edm::InputTag>( "tauSource" ));
+  tauTransverseImpactParameterSrc_ = iConfig.getParameter<edm::InputTag>( "tauTransverseImpactParameterSource" );
+  tauTransverseImpactParameterToken_ = consumes<PFTauTIPAssociationByRef>( tauTransverseImpactParameterSrc_);


Please use mayConsume, as #1988 shows that it can harm, if consumes is wrongly introduced.
This can be added as separate bug fix as soon as this one is merged, since it does not spoil tests here.

davidlange6 · 2014-01-24T10:06:05Z

+1

Reco update -- High pt taus: TauID for 2014

jpavel and others added 26 commits December 10, 2013 23:45

first steps towards merging high pt to 70x

0b6b3cd

second step towards high pt integration

4afe20a

third step

6d5a072

last step before applying patch. Brace yourself and pray

7563d3f

applied the patch. Will it work?

e59470c

post-patch bugfix in the DataFormats packages

81b2308

round 2 of postpatch bugfixes

ef605b5

fixed consumes interface in PAT tools

17cb792

first version of boosted tau code that compiles in 700

b1c3020

before PFBRECO

d3d16d8

added lifetime info

1009a9e

further updates from boosted tau branch

a68bbbf

before merging Christian changes

a313e75

added jet substructure tools for seeding boosted tau reconstruction

383a9ed

(forward-port from 5_3_X)

merged with consumes interface

2efcc8b

added consumes interface to a new part

be86680

added consumes interface to newly added files

127d5fe

added PFBRECO

dd5d47c

removing files conflicting with new tau ID and changing from Refs to …

9e7a385

…Ptrs where necessary

updated TauTagInfo from Refs to PTrs and started to modify TauTagTool…

5c6b74f

…s/PFTauElementsOperators in order to resume 'old' HLT path

Added back PFRecoTauAlgorithm for HLT taus backwards compatibility

0f45b61

Whole thing compiles

836b069

Passed all tests

50b8c54

Merged CMSSW_7_0_X_TauID2014 from repository jpavel

a70830e

Merge branch 'CMSSW_7_0_X' of https://github.com/cms-sw/cmssw into fr…

f1af450

…om-CMSSW_7_0_X_2013-12-13-1400 Updating with latest developments

rappoccio mentioned this pull request Dec 15, 2013

Switching AK5 to AK4 #1825

Closed

no need to rerun any tau ID discriminators since all relevant discrim…

7384922

…inators will run in CMSSW_7_0_x per default

vadler reviewed Jan 22, 2014
View reviewed changes

ktf added a commit that referenced this pull request Jan 27, 2014

Merge pull request #1817 from jpavel/HighPtTaus_TauID2014

477f5e7

Reco update -- High pt taus: TauID for 2014

ktf merged commit 477f5e7 into cms-sw:CMSSW_7_0_X Jan 27, 2014

jpavel mentioned this pull request Jan 31, 2014

adding ioread rules for PFTauTagInfoClass #2252

Merged

jpavel added a commit to cms-tau-pog/cmssw that referenced this pull request Feb 2, 2014

mimicking the state when the cms-sw#1817 pull request was submitted

5f5124b

jpavel added a commit to cms-tau-pog/cmssw that referenced this pull request Feb 3, 2014

changes in the tau code done during the pull request cms-sw#1817

24259f6

nclopezo modified the milestones: CMSSW_7_0_0, CMSSW_7_0_0_pre13 Feb 7, 2014

jpavel mentioned this pull request Feb 13, 2014

TauID patches #2449

Merged

jpavel mentioned this pull request Mar 28, 2014

2014 Tau ID for SLHC #3059

Merged

jpavel deleted the HighPtTaus_TauID2014 branch May 23, 2014 11:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

High pt taus: TauID for 2014 #1817

High pt taus: TauID for 2014 #1817

jpavel commented Dec 13, 2013

cmsbuild commented Dec 13, 2013

cmsbuild commented Dec 14, 2013

ktf commented Jan 20, 2014

monicava commented Jan 20, 2014

jpavel commented Jan 20, 2014

slava77 commented Jan 21, 2014

slava77 commented Jan 21, 2014

slava77 commented Jan 21, 2014

slava77 commented Jan 21, 2014

vadler commented Jan 21, 2014

deguio commented Jan 21, 2014

cmsbuild commented Jan 21, 2014

jpavel commented Jan 21, 2014

monicava commented Jan 21, 2014

deguio commented Jan 21, 2014

monicava commented Jan 21, 2014

deguio commented Jan 21, 2014

monicava commented Jan 21, 2014

cmsbuild commented Jan 22, 2014

cmsbuild commented Jan 22, 2014

vadler Jan 22, 2014

davidlange6 commented Jan 24, 2014

High pt taus: TauID for 2014 #1817

High pt taus: TauID for 2014 #1817

Conversation

jpavel commented Dec 13, 2013

cmsbuild commented Dec 13, 2013

cmsbuild commented Dec 14, 2013

ktf commented Jan 20, 2014

monicava commented Jan 20, 2014

jpavel commented Jan 20, 2014

slava77 commented Jan 21, 2014

slava77 commented Jan 21, 2014

slava77 commented Jan 21, 2014

slava77 commented Jan 21, 2014

vadler commented Jan 21, 2014

deguio commented Jan 21, 2014

cmsbuild commented Jan 21, 2014

jpavel commented Jan 21, 2014

monicava commented Jan 21, 2014

deguio commented Jan 21, 2014

monicava commented Jan 21, 2014

deguio commented Jan 21, 2014

monicava commented Jan 21, 2014

cmsbuild commented Jan 22, 2014

cmsbuild commented Jan 22, 2014

vadler Jan 22, 2014

Choose a reason for hiding this comment

davidlange6 commented Jan 24, 2014