-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[90X] Replace TMatrix by Eigen matrices and various fixes in MillePede workflow #18178
Conversation
- needed for unification of alignment producers - in addition: - `EventSetup` was nowhere used - in case of zero processed events it would be undefined
…neric `AlignmentProducerAsAnalyzer_cff`.
- add test mode to redirect it to a dummy path -> avoids eos command which depends on network connection
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
backport of #18177
This PR introduces the Eigen-based version of GBL and removes further usage of TMatrix from th MillePede workflow.
The runtime of the Mille step is reduced by approx. 30% without loss of generality and without changing the functionality.
Further changes only improve user-friendliness by adding better examples, protections and examples.
The changes of this PR are based on #18139.