Tracker Geometry Error Messages with More Details

[ianna]

• Improve error message when TrackerGeometry is asked for non-existent DetId
• Move a prototype structure from TrackerGeometry to an analyzer where it is used
• Migrate to multi-threaded analyzers
• Add test python configuration
• Add missing direct dependency
• Remove extra dependency which was already declared to remove a warning

@slava77 - Should there be an Exception thrown? Most of the downstream code does not check DetId validity any more to improve performance. I'd prefer it to crashing. It's your call.

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18880/console Started: 2017/04/03 17:33

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

CommonTools/RecoAlgos
FastSimulation/Tracking
Geometry/TrackerGeometryBuilder
RecoTracker/GeometryESProducer
RecoTracker/TkDetLayers

@perrotta, @civanch, @Dr15Jones, @lveldere, @ianna, @mdhildreth, @cmsbuild, @ssekmen, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @rappoccio, @jdolen, @makortel, @felicepantaleo, @abbiendi, @GiacomoSguazzoni, @mschrode, @rovere, @VinInn, @Martin-Grunewald, @ahinzmann, @gkasieczka, @jhgoh, @gpetruc, @matt-komm, @ebrondol, @dgulhan, @venturia this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[slava77]

Should there be an Exception thrown? 
Most of the downstream code does not check DetId validity any more to improve performance. 
I'd prefer it to crashing. 
It's your call.

seems OK to throw for the cases here

[cmsbuild]

+1
Tested at: 817511b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18182/18880/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18182/18880/summary.html

[cmsbuild]

Pull request #18182 was updated. @perrotta, @civanch, @Dr15Jones, @lveldere, @ianna, @mdhildreth, @cmsbuild, @ssekmen, @slava77, @davidlange6 can you please check and sign again.

[ianna]

please test

[cmsbuild]

-1

Tested at: 62bc0f0

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18182/18903/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-03-2300/src/DQMServices/Core/test/DQMMonitorUIRootStandaloneExample.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-03-2300/src/DQMServices/Core/test/DQMSourceExampleConfig.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-03-2300/src/DQMServices/Core/test/DQMBackEndInterfaceQTestsExample.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-03-2300/src/DQMServices/Core/test/DQMTestMultiThread.cc 
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-03-2300/src/SLHCUpgradeSimulations/Geometry/src/PrintGeomMatInfo.cc: In member function 'void PrintGeomMatInfo::dumpSummary(std::ostream&)':
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-03-2300/src/SLHCUpgradeSimulations/Geometry/src/PrintGeomMatInfo.cc:174:11: error: 'G4PhysicalVolumeStore' does not name a type
     const G4PhysicalVolumeStore * pvs = G4PhysicalVolumeStore::GetInstance();
           ^
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-03-2300/src/SLHCUpgradeSimulations/Geometry/src/PrintGeomMatInfo.cc:175:50: error: 'pvs' was not declared in this scope
     out << " Number of G4VPhysicalVolume's: " << pvs->size() << std::endl;
                                                  ^


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[ianna]

@smuzaffar - is this IB broken?

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18912/console Started: 2017/04/04 16:39

[cmsbuild]

+1
Tested at: 62bc0f0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18182/18912/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18182/18912/summary.html

[ianna]

+1

[slava77]

+1

for #18182 62bc0f0

• technical changes in the reco packages, affecting only /test files; the upstream geomtery updates are OK
• jenkins tests pass and comparisons show no differences