-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracker Geometry Error Messages with More Details #18182
Tracker Geometry Error Messages with More Details #18182
Conversation
* Move test structure in an analyzer where it is used * Migrate to multi-threaded analyzer * Add python configuration for test * Add missing direct dependency
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: CommonTools/RecoAlgos @perrotta, @civanch, @Dr15Jones, @lveldere, @ianna, @mdhildreth, @cmsbuild, @ssekmen, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
seems OK to throw for the cases here |
Comparison job queued. |
Pull request #18182 was updated. @perrotta, @civanch, @Dr15Jones, @lveldere, @ianna, @mdhildreth, @cmsbuild, @ssekmen, @slava77, @davidlange6 can you please check and sign again. |
please test |
-1 Tested at: 62bc0f0 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found an error when building: >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-03-2300/src/DQMServices/Core/test/DQMMonitorUIRootStandaloneExample.cc >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-03-2300/src/DQMServices/Core/test/DQMSourceExampleConfig.cc >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-03-2300/src/DQMServices/Core/test/DQMBackEndInterfaceQTestsExample.cc >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-03-2300/src/DQMServices/Core/test/DQMTestMultiThread.cc /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-03-2300/src/SLHCUpgradeSimulations/Geometry/src/PrintGeomMatInfo.cc: In member function 'void PrintGeomMatInfo::dumpSummary(std::ostream&)': /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-03-2300/src/SLHCUpgradeSimulations/Geometry/src/PrintGeomMatInfo.cc:174:11: error: 'G4PhysicalVolumeStore' does not name a type const G4PhysicalVolumeStore * pvs = G4PhysicalVolumeStore::GetInstance(); ^ /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-03-2300/src/SLHCUpgradeSimulations/Geometry/src/PrintGeomMatInfo.cc:175:50: error: 'pvs' was not declared in this scope out << " Number of G4VPhysicalVolume's: " << pvs->size() << std::endl; ^ |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
@smuzaffar - is this IB broken? |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
@slava77 - Should there be an Exception thrown? Most of the downstream code does not check DetId validity any more to improve performance. I'd prefer it to crashing. It's your call.