Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow processingMode RunsAndLumis for ALCAHARVEST when using DAS queries #18210

Merged
merged 1 commit into from
Apr 14, 2017

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 5, 2017

E.g.:

cmsDriver.py step7 --data --conditions auto:run1_data --scenario pp -s ALCAHARVEST:SiPixelAli --dasquery='file dataset=/StreamExpress/Run2016H-PromptCalibProdSiPixelAli-Express-v2/ALCAPROMPT run=283407' -n -1

won't run correctly. Is there any reason not to support this mode? Might come in handy for certain performance checks.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2017

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Configuration/Applications

@cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@franzoni
Copy link

pelase test

@mmusich
Copy link
Contributor Author

mmusich commented Apr 12, 2017

Hi Giovanni @franzoni, I suspect the typo won't make the bot aware of the command

@franzoni
Copy link

please test

@franzoni
Copy link

( thanks @mmusich )

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 12, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19152/console Started: 2017/04/12 18:51

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18210/19152/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1921593
  • DQMHistoTests: Total failures: 14948
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1906472
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@franzoni
Copy link

No difference in standard MC or data tests based on relval.

W/ and w/o this PR the difference in the test cmsDriver.py command:

 colordiff step7_ALCAHARVEST.py vanilla-step7_ALCAHARVEST.py
16d15
<     processingMode = cms.untracked.string('RunsAndLumis'),

is what's intended.

@franzoni
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c718e6e into cms-sw:master Apr 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants