Add V0s to miniaod #18300

arizzi · 2017-04-10T20:40:16Z

Add k0 and lambdas from generalV0Candidates producer.
V0s are converted to VertexCompositePtrCandidate and rekeyed to point to packedPFcandidate.
In addition tracks from V0s are white listed

Size increase is 150bytes/event on ttbar
http://arizzi.web.cern.ch/arizzi/miniaod/plusK0.html#recoVertexCompositePtrCandidates_slimmedKshortVertices__PAT

this PR is on top of most recent version of #18092

cmsbuild · 2017-04-10T20:40:37Z

A new Pull Request was created by @arizzi for master.

It involves the following packages:

DataFormats/PatCandidates
PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @JyothsnaKomaragiri, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @cbernet this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

perrotta · 2017-04-10T20:54:24Z

please test

cmsbuild · 2017-04-10T20:54:39Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19073/console Started: 2017/04/10 22:55

cmsbuild · 2017-04-10T23:00:19Z

+1
Tested at: af6e292
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18300/19073/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a782fc5
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18300/19073/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18300/19073/git-merge-result

cmsbuild · 2017-04-10T23:00:22Z

Comparison job queued.

cmsbuild · 2017-04-11T00:44:36Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18300/19073/summary.html

Comparison Summary:

You potentially added 7 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 3219 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1917209
DQMHistoTests: Total failures: 30977
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1886059
DQMHistoTests: Total skipped: 173
DQMHistoTests: Total Missing objects: 0
Checked 94 log files, 14 edm output root files, 23 DQM output files

alberto-sanchez · 2017-04-11T01:09:36Z

@arizzi, working on that.

arizzi · 2017-04-11T19:50:10Z

same update as #18092 to avoid root files in release

cmsbuild · 2017-04-11T19:51:13Z

Pull request #18300 was updated. @perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please check and sign again.

slava77 · 2017-04-13T14:45:36Z

@arizzi
there are merge conflicts here.
Please rebase or remake&force-push

arizzi · 2017-04-13T14:58:11Z

everything is in the last commit, I'll cherry pick and force update

cmsbuild · 2017-04-13T17:17:29Z

+1
Tested at: 4b691fa
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18300/19168/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
dc786e5
dfc18bc
18fc178
993f5c5
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18300/19168/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18300/19168/git-merge-result

cmsbuild · 2017-04-13T17:17:32Z

Comparison job queued.

cmsbuild · 2017-04-13T18:50:28Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18300/19168/summary.html

Comparison Summary:

You potentially added 786 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 3267 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1818598
DQMHistoTests: Total failures: 40859
DQMHistoTests: Total nulls: 13
DQMHistoTests: Total successes: 1777553
DQMHistoTests: Total skipped: 173
DQMHistoTests: Total Missing objects: 0
Checked 94 log files, 14 edm output root files, 23 DQM output files

slava77 · 2017-04-14T13:14:58Z

@cmsbuild please test
to get cleaner comparisons now that CMSSW_9_1_X_2017-04-13-2300 is available (effective merge base for this PR)

cmsbuild · 2017-04-14T13:15:13Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19183/console Started: 2017/04/14 15:15

cmsbuild · 2017-04-14T14:51:58Z

+1
Tested at: 4b691fa
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18300/19183/summary.html

cmsbuild · 2017-04-14T14:52:01Z

Comparison job queued.

cmsbuild · 2017-04-14T17:28:42Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18300/19183/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 3187 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1818576
DQMHistoTests: Total failures: 30780
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 1787622
DQMHistoTests: Total skipped: 173
DQMHistoTests: Total Missing objects: 0
Checked 94 log files, 14 edm output root files, 23 DQM output files

slava77 · 2017-04-17T19:28:43Z

PhysicsTools/PatAlgos/plugins/PATSecondaryVertexSlimmer.cc

@@ -32,6 +37,7 @@ namespace pat {
 pat::PATSecondaryVertexSlimmer::PATSecondaryVertexSlimmer(const edm::ParameterSet& iConfig) :
  src_(consumes<reco::VertexCompositePtrCandidateCollection>(iConfig.getParameter<edm::InputTag>("src"))),
  srcLegacy_(mayConsume<std::vector<reco::Vertex> >(iConfig.getParameter<edm::InputTag>("src"))),
+  srcV0s_(mayConsume<reco::VertexCompositeCandidateCollection>(iConfig.getParameter<edm::InputTag>("src"))),


this runtime input type detection is getting only worse.
Please change the module configuration to pass the type to be used at configuration step.

@Dr15Jones is proliferation of this mayConsume to different types OK for the framework, or do we get some unwanted cost?

mayConsumes is presently (and may always) trigger prefetching of the item requested. It is possible to determine what type is available before calling consumes. This is done by registering a function to call when new products are registered. The registration is done by passing a functor to callWhenNewProductsRegistered. The documentation can be found here:
https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideEDMGetDataFromEvent#GetterOfProducts

slava77 · 2017-04-18T17:54:04Z

+1

for #18300 4b691fa

implemented as described
jenkins tests pass and comparisons show differences in packed candidate delta plots where more cands have filled values (more so in the /lostTrack folder) as expected
local test with PAT step running on 136.76 (2016E double muon) shows addition of slimmedKshortVertices and slimmedLambdaVertices modules which take under 0.1ms/event total and produce VertexCompositePtrCandidates collections with size consistent with what's in the PR description.

#18390 is created to possibly follow up on implementation of PhysicsTools/PatAlgos/plugins/PATSecondaryVertexSlimmer.cc

cmsbuild added this to the Next CMSSW_9_1_X milestone Apr 10, 2017

cmsbuild added analysis-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Apr 10, 2017

cmsbuild added tests-started and removed tests-pending labels Apr 10, 2017

cmsbuild added tests-approved and removed tests-started labels Apr 10, 2017

cmsbuild added comparison-available and removed comparison-pending labels Apr 11, 2017

arizzi force-pushed the v0miniaod branch from af6e292 to 74bf290 Compare April 11, 2017 19:49

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Apr 11, 2017

Add V0 to miniAOD

4b691fa

cmsbuild added tests-started and removed tests-pending labels Apr 13, 2017

cmsbuild added tests-approved and removed tests-started labels Apr 13, 2017

cmsbuild added comparison-available and removed comparison-pending labels Apr 13, 2017

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Apr 14, 2017

cmsbuild added tests-started and removed tests-pending labels Apr 14, 2017

cmsbuild added tests-approved and removed tests-started labels Apr 14, 2017

cmsbuild added comparison-available and removed comparison-pending labels Apr 14, 2017

slava77 reviewed Apr 17, 2017

View reviewed changes

slava77 mentioned this pull request Apr 18, 2017

refactor PATSecondaryVertexSlimmer.cc to reduce run-time type detection and mayConsume use #18390

Closed

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Apr 18, 2017

davidlange6 merged commit 4291aa9 into cms-sw:master Apr 21, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add V0s to miniaod #18300

Add V0s to miniaod #18300

arizzi commented Apr 10, 2017

cmsbuild commented Apr 10, 2017

perrotta commented Apr 10, 2017

cmsbuild commented Apr 10, 2017 •

edited

Loading

cmsbuild commented Apr 10, 2017

cmsbuild commented Apr 10, 2017

cmsbuild commented Apr 11, 2017

alberto-sanchez commented Apr 11, 2017

arizzi commented Apr 11, 2017

cmsbuild commented Apr 11, 2017

slava77 commented Apr 13, 2017

arizzi commented Apr 13, 2017

cmsbuild commented Apr 13, 2017

cmsbuild commented Apr 13, 2017

cmsbuild commented Apr 13, 2017

slava77 commented Apr 14, 2017

cmsbuild commented Apr 14, 2017 •

edited

Loading

cmsbuild commented Apr 14, 2017

cmsbuild commented Apr 14, 2017

cmsbuild commented Apr 14, 2017

slava77 Apr 17, 2017

Dr15Jones Apr 18, 2017

slava77 commented Apr 18, 2017

Add V0s to miniaod #18300

Add V0s to miniaod #18300

Conversation

arizzi commented Apr 10, 2017

cmsbuild commented Apr 10, 2017

perrotta commented Apr 10, 2017

cmsbuild commented Apr 10, 2017 • edited Loading

cmsbuild commented Apr 10, 2017

cmsbuild commented Apr 10, 2017

cmsbuild commented Apr 11, 2017

alberto-sanchez commented Apr 11, 2017

arizzi commented Apr 11, 2017

cmsbuild commented Apr 11, 2017

slava77 commented Apr 13, 2017

arizzi commented Apr 13, 2017

cmsbuild commented Apr 13, 2017

cmsbuild commented Apr 13, 2017

cmsbuild commented Apr 13, 2017

slava77 commented Apr 14, 2017

cmsbuild commented Apr 14, 2017 • edited Loading

cmsbuild commented Apr 14, 2017

cmsbuild commented Apr 14, 2017

cmsbuild commented Apr 14, 2017

slava77 Apr 17, 2017

Choose a reason for hiding this comment

Dr15Jones Apr 18, 2017

Choose a reason for hiding this comment

slava77 commented Apr 18, 2017

cmsbuild commented Apr 10, 2017 •

edited

Loading

cmsbuild commented Apr 14, 2017 •

edited

Loading