Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and Improvements for conddb tools #18329

Merged

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Apr 12, 2017

In this PR:

Fix for o2o listJobs command, to get a list ordered by job name
Fix handling of o2o return code to get a single line for non-verbose output in case of error
Fix handling of return code for upload failure in popcon
Adding listRuns func in conddb
Adding showFCSR func in conddb

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ggovi for CMSSW_9_0_X.

It involves the following packages:

CondCore/Utilities

@ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1 this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@ggovi
Copy link
Contributor Author

ggovi commented Apr 12, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 12, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19140/console Started: 2017/04/12 15:28

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18329/19140/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 48 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1880538
  • DQMHistoTests: Total failures: 29557
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 1850807
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@ggovi
Copy link
Contributor Author

ggovi commented Apr 19, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

Pull request #18329 was updated. @ggovi, @cmsbuild, @davidlange6 can you please check and sign again.

@ggovi
Copy link
Contributor Author

ggovi commented Apr 19, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 19, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19238/console Started: 2017/04/19 11:51

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@ggovi
Copy link
Contributor Author

ggovi commented Apr 19, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18329/19238/summary.html

Comparison Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1884660
  • DQMHistoTests: Total failures: 44288
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1840199
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c4e8392 into cms-sw:CMSSW_9_0_X Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants