Made function static const in SiPixelDetInfoFileReader

[Dr15Jones]

No description provided.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CalibTracker/SiPixelESProducers

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @dkotlins, @tocheng this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19150/console Started: 2017/04/12 18:40

[cmsbuild]

+1
Tested at: 12744e9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18336/19150/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
cf6bf1f
c5bffcb
a05cf7f
a0502f5
44bc494
ce616fe
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18336/19150/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18336/19150/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18336/19150/summary.html

Comparison Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 3243 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1921525
• DQMHistoTests: Total failures: 30795
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1890557
• DQMHistoTests: Total skipped: 173
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files

[arunhep]

@Dr15Jones with only little change in this PR, do we expect changes in these distributions?

https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_9_1_X_2017-04-11-2300+18336/19418/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/PixelPhase1_Tracks_PXForward_HalfCylinder_mI_PXRing_2_PXDisk_-1.html

its everywhere in PixelPhase1 directory.

[Dr15Jones]

It is not possible for this change to affect any algorithm. Do we know if the results being compared use the same random numbers or same pile up?

[arunhep]

i dont find any other change in any directory, events should be same. may be @slava77 @perrotta can help?
even the changes are not visible in every layer or ring. for example here in barrel layer 4 we see changes but not in other three layers
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_9_1_X_2017-04-11-2300+18336/19418/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/PixelPhase1_Tracks_PXBarrel_Shell_pO_PXLayer_4.html

[Dr15Jones]

@slava77 @perrotta ping

[perrotta]

@arunhep @Dr15Jones

What I notice is that in #18336 (comment) it is said that

"The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
...
44bc494
..."

And 44bc494 is the merge commit for #18278. If you look at the jenkins tests for that PR you can notice the very same features observed here. Therefore, I can imagine that those phase 1 SiPixel plots had been emptied by #18278, and not by this PR (I would be surprised to observe any such consequence because of the changes applied here, indeed).

Whether these observed modifications in the DQM outputs are correct or not should have had been discussed in #18278: I don't see why it should be as such given the description of that PR, but I did not investigate ...

[arunhep]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar