-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure validation scripts #18365
Conversation
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
+1 |
@rovere @ianna , looks like this PR broke the Material Budget IB tests https://cmssdt.cern.ch/jenkins/job/ib-run-material-budget/681/console
reason is that the plot_utils.py is not in PYTHONPATH. @rovere , may be move Validation/Geometry/test/plot_utils.py to Validation/Geometry/python/plot_utils.py |
I'll make a separate PR soonish. Thanks for reporting. |
@rovere , looks like Validation/Geometry/test/MaterialBudget.C is also needed by material budget tests |
@ianna @smuzaffar |
this is what we run https://github.com/cms-sw/cms-bot/blob/master/run-material-budget For comparison we run https://github.com/cms-sw/cms-bot/blob/master/compare-material-budget |
@smuzaffar @ianna |
thanks @rovere . cms-bot changes worked. |
No description provided.