Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Memory Leak in JetCorrectorParametersHelper #18415

Merged
merged 5 commits into from
May 17, 2017
Merged

Fix Memory Leak in JetCorrectorParametersHelper #18415

merged 5 commits into from
May 17, 2017

Conversation

aperloff
Copy link
Contributor

This PR fixes the issue discussed at #18160. There are new conditions checks and unit tests added to the package and a memory leak was fixed. None of this should affect the underlying behavior of the code nor its speed.

@cmsbuild cmsbuild added this to the Next CMSSW_9_1_X milestone Apr 20, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 20, 2017 •
edited by smuzaffar
Loading

A new Pull Request was created by @aperloff (Alexx Perloff) for master.

It involves the following packages:

CondFormats/JetMETObjects

@ggovi, @cmsbuild, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gkasieczka, @apfeiffer1, @schoef, @mariadalfonso this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

@aperloff aperloff mentioned this pull request Apr 20, 2017
Closed
@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 20, 2017 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19299/console Started: 2017/04/20 17:03

@Dr15Jones
Copy link
Contributor

As far as I can tell, this doesn't fix a memory leak, but instead avoids an out-of-memory-bounds read.

@aperloff
Copy link
Contributor Author

@Dr15Jones, yes, you are right.

@cmsbuild
Copy link
Contributor

+1
Tested at: 4fe1f4e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18415/19299/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18415/19299/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3308 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1826205
  • DQMHistoTests: Total failures: 15789
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1810243
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@aperloff
Copy link
Contributor Author

Looks to me like all the checks passed. Only the DQM-TimerService has some small differences.

@aperloff
Copy link
Contributor Author

@Dr15Jones Just checking in to see if we can merge this PR. Didn't want it to fall by the wayside.

@Dr15Jones
Copy link
Contributor

@aperloff I'm afraid this change is not under my L2 area so I have no say as to it being merged. This requires signatures from analysis and db L2 areas.

@aperloff
Copy link
Contributor Author

@Dr15Jones Who are the analysis and db L2 contacts that I need to ping?

@Dr15Jones
Copy link
Contributor

The second comment in this thread lists the people responsible. It was this sentence:

@ggovi, @cmsbuild, @monttj, @davidlange6 can you please review it and eventually sign?

davidlange6 just signs for ops and cmsbuild is just the test system. That leaves @ggovi and @monttj who are the L2s who have to sign.

@kpedro88
Copy link
Contributor

kpedro88 commented May 1, 2017

@ggovi @monttj please review/sign

@davidlange6
Copy link
Contributor

hi @aperloff - the 14 MB file needs to be removed - can it be automatically generated as part of the unit test?

@smuzaffar smuzaffar added this to the CMSSW_9_2_X milestone May 4, 2017
@cmsbuild
Copy link
Contributor

Pull request #18415 was updated. @ggovi, @cmsbuild, @monttj, @davidlange6 can you please check and sign again.

@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

Pull request #18415 was updated. @ggovi, @cmsbuild, @monttj, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 10, 2017 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19721/console Started: 2017/05/10 16:26

@cmsbuild
Copy link
Contributor

+1
Tested at: 42a754b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18415/19721/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18415/19721/summary.html

Comparison Summary:

  • You potentially added 34 lines to the logs
  • Reco comparison results: 1766 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1830372
  • DQMHistoTests: Total failures: 37708
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1792484
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@kpedro88
Copy link
Contributor

@ggovi @monttj please sign

@ggovi
Copy link
Contributor

ggovi commented May 16, 2017

+1

@davidlange6
Copy link
Contributor

@aperloff - thanks - but please fix the tab vs 3-space indentation issues introduced in this PR via a followup PR.

@davidlange6 davidlange6 merged commit 6096ac4 into cms-sw:master May 17, 2017
@aperloff aperloff mentioned this pull request May 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending comparison-available db-approved orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_9_2_X
Development

Successfully merging this pull request may close these issues.
7 participants
@aperloff @cmsbuild @Dr15Jones @kpedro88 @davidlange6 @ggovi @smuzaffar