converted to global ESDigiToRaw

[sabasehrish]

@Dr15Jones

[cmsbuild]

A new Pull Request was created by @sabasehrish (Saba Sehrish) for master.

It involves the following packages:

EventFilter/ESDigiToRaw

@mommsen, @cmsbuild, @emeschi, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19472/console Started: 2017/04/28 20:04

[cmsbuild]

+1
Tested at: 124e5ee
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18521/19472/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18521/19472/summary.html

Comparison Summary:

• You potentially added 28 lines to the logs
• Reco comparison results: 1690 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1778755
• DQMHistoTests: Total failures: 41925
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1736657
• DQMHistoTests: Total skipped: 173
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files

[Dr15Jones]

ping

[mommsen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22117/console Started: 2017/08/07 09:59

[cmsbuild]

+1
Tested at: 124e5ee
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18521/22117/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
909ea2f
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18521/22117/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18521/22117/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18521/22117/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 25
• DQMHistoTests: Total histograms compared: 2643105
• DQMHistoTests: Total failures: 191
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2642733
• DQMHistoTests: Total skipped: 181
• DQMHistoTests: Total Missing objects: 0
• Checked 102 log files, 14 edm output root files, 25 DQM output files

[davidlange6]

+1