Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing PhysicsTools/UtilAlgos unit tests so it works outside of cern #18534

Merged
merged 1 commit into from May 3, 2017

Conversation

Sam-Harper
Copy link
Contributor

At RAL at least, if you dont specify eoscms.cern.ch and just do eoscms, it fails.

This PR just adds the .cern.ch to the file addresss so I can run unit tests easier.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2017

A new Pull Request was created by @Sam-Harper for master.

It involves the following packages:

PhysicsTools/UtilAlgos

@cmsbuild, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

@Sam-Harper Sam-Harper changed the title fixing so works outside of cern fixing PhysicsTools/UtilAlgos unit tests so it works outside of cern May 1, 2017
@davidlange6
Copy link
Contributor

dumb question - does just using the universal /store/.... not work here?

@Sam-Harper
Copy link
Contributor Author

Not dumb. That was my first thought. Had problems with that too. I think its because whats running is not cmsRun and therefore doesnt know about these things. I didnt bother to investigate.

FWLiteWithBasicAnalyzer test/fwliteWithPythonConfig_cfg.py
Error in TFile::TFile: file /store/relval/CMSSW_7_2_0_pre5/RelValProdTTbar/GEN-SIM-RECO/START72_V1-v1/00000/022350A9-AC30-E411-B225-0025905A6076.root does not exist

*** Break *** segmentation violation

@davidlange6
Copy link
Contributor

please test
(weird, thanks for the followup)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19491/console Started: 2017/05/02 10:25

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18534/19491/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1676 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1778687
  • DQMHistoTests: Total failures: 38184
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1740330
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@davidlange6 davidlange6 merged commit 3731902 into cms-sw:master May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants