-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mini-isolation for leptons and a new collection of Isolated Tracks in MiniAOD #18548
Conversation
…ted Track candidates
A new Pull Request was created by @bjmarsh (Bennett Marsh) for master. It involves the following packages: DataFormats/PatCandidates @perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 merge conflicts should be resolved first |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
@@ -8,19 +8,18 @@ | |||
of packed PF candidates | |||
|
|||
Mini-Isolation reference: https://hypernews.cern.ch/HyperNews/CMS/get/susy/1991.html | |||
|
|||
typedef ROOT::Math::LorentzVector<ROOT::Math::PxPyPzE4D<double> > LorentzVector; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this typedef needed here inside the documentation lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not, that's a mistake.. must have accidentally pasted it after I deleted it below and didn't catch it. I can remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove.
Thank you.
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
here is a comparison in matrix wf 136.761 used for local tests of this PR previously red is for the latest version and black is with 7111208 |
@davidlange6 Thank you. |
@davidlange6 Thank you. |
Store pre-computed mini-isolation variables in PAT Electrons and Muons. Stores the four components: charged hadron, neutral hadron, photon, and pileup.
Add a collection of new class pat::IsolatedTrack (inherits from reco::LeafCandidate). Picks out packed PF candidates that satisfy: charged, pT>5, (fromPV>1 || abs(dz)<0.1), (trackIso<5 GeV || relTrackIso<0.2 || relMiniTrackIso<0.2). Stores p4, pdgId, charge, dz, dxy, and the four components of both regular (dR=0.3) and mini isolation. Also a reference to the original packed candidate.
Tested on a sample of DY MC and validated the isolation values. In total, the additions add just over 100 bytes/event on average.