speed up pixel DQM initialization by a factor >10 #18610
Conversation
|
A new Pull Request was created by @VinInn (Vincenzo Innocente) for master. It involves the following packages: CondFormats/SiPixelObjects @ghellwig, @arunhep, @cerminar, @dmitrijus, @cmsbuild, @franzoni, @ggovi, @mmusich, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| std::map<uint32_t, unsigned int> fedid_; | ||
| std::map<uint64_t, unsigned int> channel_; | ||
| std::map<uint64_t, unsigned int> roc_; | ||
| std::unordered_map<uint32_t, int> quadrant_; |
There was a problem hiding this comment.
all these maps HAVE to be filled at initialization, not on demand...
| @@ -35,6 +35,7 @@ void SiPixelCoordinates::init(edm::EventSetup const& iSetup) { | |||
| edm::ESHandle<SiPixelFedCablingMap> cablingMapHandle; | |||
| iSetup.get<SiPixelFedCablingMapRcd>().get(cablingMapHandle); | |||
| cablingMap_ = cablingMapHandle.product(); | |||
| fedid_ = cablingMap_->det2fedMap(); | |||
There was a problem hiding this comment.
fedid() method have to be cleanup...
| { | ||
| // Build map | ||
| buildStructure(iSetup); | ||
| // buildStructure(iSetup); |
There was a problem hiding this comment.
this is now obsolete, need to be cleanup.
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
I suggest to merge this (and even backport to 91X) |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
+1 |
|
ping |
|
indeed quite some cleanup is needed here - who is planning to do it? @fioriNTU |
|
@davidlange6 I will plan on the cleanup in this week, it is among our priorities |
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
from >10 minutes to one minute
see issue #18606
need further cleanup (and verification!)