Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update on SiStrip O2O #18613

Merged
merged 5 commits into from May 9, 2017
Merged

Update on SiStrip O2O #18613

merged 5 commits into from May 9, 2017

Conversation

hqucms
Copy link
Contributor

@hqucms hqucms commented May 8, 2017

Includes all O2O scripts for SiStrip DAQ/DCS, and code changes for the new G1 O2O.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2017

A new Pull Request was created by @hqucms for master.

It involves the following packages:

CondTools/SiStrip
OnlineDB/SiStripESSources
OnlineDB/SiStripO2O

@ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@VinInn this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@ggovi
Copy link
Contributor

ggovi commented May 8, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19643/console Started: 2017/05/08 16:05

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2017

Pull request #18613 was updated. @ggovi, @cmsbuild, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18613/19643/summary.html

There are some workflows for which there are errors in the baseline:
23234.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • You potentially added 5479 lines to the logs
  • Reco comparison results: 3366 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1777942
  • DQMHistoTests: Total failures: 33205
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1744564
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

Pull request #18613 was updated. @ggovi, @cmsbuild, @davidlange6 can you please check and sign again.

@ggovi
Copy link
Contributor

ggovi commented May 9, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19657/console Started: 2017/05/09 09:10

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

Comparison job queued.

@ggovi
Copy link
Contributor

ggovi commented May 9, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7f88203 into cms-sw:master May 9, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18613/19657/summary.html

Comparison Summary:

  • You potentially added 2615 lines to the logs
  • Reco comparison results: 1689 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831050
  • DQMHistoTests: Total failures: 41724
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1789146
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants