-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not put temporary TF1 into ROOT's global function pool #18636
Conversation
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: RecoVertex/BeamSpotProducer @perrotta, @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @slava77, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
TF1 gausy("localGausY","gaus"); | ||
TF1 gausz("localGausZ","gaus"); | ||
// also do not add to global list of functions | ||
TF1 gausx("localGausX","gaus",false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dr15Jones The 3rd argument in the case of TF1 is a different type than in the case of a TFormula. For TF1, it is a TF1::EAddToList
// Add to list behavior
enum class EAddToList {
kDefault,
kAdd,
kNo
};
so this code actually 'still' request the addition to the list (i.e. kDefault)
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
please test |
The tests are being triggered in jenkins. |
I found one more case of a TF1 being added to the global list. That was the last case in the package. |
Comparison job queued. |
This change is purely technical. I was forced to also add the extra arguments to the TF1 constructor which match the defaults used by ROOT: |
type bug |
urgent |
+1 |
To be more clear, I do not promise that this will fix the crash we are seeing. By getting this in, if we have another crash we will have eliminated one of the most obvious concentenders we presently have. Plus, not putting the TF1 into the global list is just a plain good idea to avoid other potential problems as well as make the code a bit more thread efficient. |
Comparison is ready Comparison Summary:
|
No description provided.